Skip to content

fix(action_hook): parsing int collection pk on action hook #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbarreau merged 2 commits into from
Jan 22, 2025
Merged

fix(action_hook): parsing int collection pk on action hook #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2181f04
fix(hook_collection_field): collection pk parsing on action hook
jbarreau Jan 22, 2025
300d930
chore: add a quick test to show the issue
jbarreau Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agent_toolkit/forestadmin/agent_toolkit/utils/forest_schema/action_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def value_to_forest(field: ActionField, value: Any) -> Any:

elif field["type"] == ActionFieldType.COLLECTION and value:
value = cast(CompositeIdAlias, value)
return "|".join(value)
return "|".join([str(v) for v in value])

elif field["type"] == ActionFieldType.FILE and value:
return ForestValueConverter._make_data_uri(value)
Expand Down
24 changes: 24 additions & 0 deletions src/agent_toolkit/tests/utils/forest_schema/test_action_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,30 @@ def test_should_transform_multi_pk_into_composite(self):
"1|2",
)

def test_should_parse_correctly_pks_when_they_are_integer(self):
self.assertEqual(
ForestValueConverter.value_to_forest(
{
"type": ActionFieldType.COLLECTION,
"watch_changes": False,
"label": "test_enum",
},
[1],
),
"1",
)
self.assertEqual(
ForestValueConverter.value_to_forest(
{
"type": ActionFieldType.COLLECTION,
"watch_changes": False,
"label": "test_enum",
},
[1, 2],
),
"1|2",
)

def test_should_transform_file_into_datauri(self):
self.assertEqual(
ForestValueConverter.value_to_forest(
Expand Down
Loading