Skip to content

Conversation

@smurfix
Copy link
Contributor

@smurfix smurfix commented Nov 13, 2020

Drop built-in msgfmt

@sallner
Copy link
Contributor

sallner commented Nov 13, 2020

We have now the problem, that this is not building on Python 2. We either stop supporting it right now or you could rewrite it without pathlib. I added some github actions which check the install process. Please rebase this changes on master again.

@smurfix
Copy link
Contributor Author

smurfix commented Nov 13, 2020

I have no problem with not supporting Py2 any more, but that'd require version 1.6.0 IMHO. Probably not a bad idea in any case.

@sallner
Copy link
Contributor

sallner commented Nov 13, 2020

It should then be a 2.0. but it seems, that at least in GHA the installation does not work with Python 3. It seemed to work with tox locally though.

@smurfix
Copy link
Contributor Author

smurfix commented Nov 13, 2020

Yeah, it should, but this isn't the only package that has taken sort of a middle-of-the-road approach on this – as strictly speaking it's not formalchemy that discontinued Py2 support but Python itself.

@shasan-beanfield
Copy link

shasan-beanfield commented Jul 31, 2023

Hi, is it possible to deploy this as a bug fix? We need to be able to install this for upgrading to python 3.8 or above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants