Skip to content

fix: throw exception on form submit error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fdchriswaechter wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: throw exception on form submit error #4

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4923df2
fix: set variable with default value
fdchriswaechter Oct 14, 2024
bf3f66c
fix: remove try catch in submitForm
fdchriswaechter Oct 15, 2024
89f24ca
Merge branch 'file_upload' into b_correct-exception-handling
fdchriswaechter Mar 3, 2025
9659e09
refactor: use namespace from Psr
fdchriswaechter Mar 3, 2025
b10f7e2
chore: remove logger injection
fdchriswaechter Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions Classes/Service/HubSpotService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use HubSpot\Discovery\Discovery;
use Neos\Flow\Annotations as Flow;
use Psr\Log\LoggerInterface;
use Psr\Http\Message\ResponseInterface;

/**
* @Flow\Scope("singleton")
Expand All @@ -23,12 +23,6 @@ class HubSpotService
*/
protected Discovery $hubspotApi;

/**
* @Flow\Inject
* @var LoggerInterface
*/
protected $logger;

/**
* @return void
*/
Expand All @@ -41,9 +35,9 @@ public function initializeObject(): void {
* @param array $formFields
* @param array $context
* @param array $legalConsentOptions
* @return \Psr\Http\Message\ResponseInterface
* @return ResponseInterface
*/
public function submitForm(string $formGuid, array $formFields, array $context, array $legalConsentOptions): \Psr\Http\Message\ResponseInterface {
public function submitForm(string $formGuid, array $formFields, array $context, array $legalConsentOptions): ResponseInterface {

$requestOptions = [
'method' => 'POST',
Expand All @@ -56,13 +50,7 @@ public function submitForm(string $formGuid, array $formFields, array $context,
],
];

try {
$response = $this->hubspotApi->apiRequest($requestOptions);
} catch (\GuzzleHttp\Exception\ClientException $e) {
$this->logger->error('Error during form submit to HubSpot: '. $e->getMessage());
}

return $response;
return $this->hubspotApi->apiRequest($requestOptions);
}

}