fix: update Redis dependency to version 0.32 and improve error handli… #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in async item retrieval
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Redis library from version 0.27.6 to 0.32.7 and adds proper error handling for iterator operations in the scan and zscan methods.
Key Changes
- Upgraded
rediscrate from version 0.27.6 to 0.32 with additional features includingtokio-native-tls-compandsafe_iterators - Added error handling for
next_item()calls inscanandzscanmethods to properly propagate Redis iterator errors - Updated dependency tree to reflect the new Redis version and its transitive dependencies
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/key-value-store/Cargo.toml | Upgrades redis dependency to 0.32 and adds tokio-native-tls-comp and safe_iterators features |
| crates/key-value-store/src/redis_impl.rs | Adds error handling for iterator next_item() calls in scan and zscan methods |
| Cargo.lock | Updates lockfile with new redis version and adjusted dependency tree |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qrdl
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng in async item retrieval