-
Notifications
You must be signed in to change notification settings - Fork 8
SMT Updates/Improvements #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CB-quakemodel
wants to merge
23
commits into
master
Choose a base branch
from
more_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements:
Add CEUS 2020 site term to ModifiableGMPE from toml parser + unit test and document it
Splitting tests for sammons and euclidean matrix plots + testing using not just median, now also 16th and 84th percentiles.
Expand unit test for GMC from XML (instead of from the toml) to include a third TRT. The third TRT's branchset contains GMMs already present in both of the other TRTs.
Using dictionaries for storing GMM LTs to make things more explicit and flexible elsewhere. For example:
Ability to customise the labels used for GMM logic tree plotting (for example, we might want to labelled a given logic tree as the "updated GMC" or "original GMC" logic tree in the plots, rather than just "logic tree 1" or "logic tree 2"
When plotting from an XML add the TRT of the LT in that file to the plot legends and exporting functions by overwriting the default labels in such instances