Feature/acollow/hemcoemissions #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acollow
added
0 diff trivial
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff trivial, Contingent - DNA |
2 similar comments
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff trivial, Contingent - DNA |
|
Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff trivial, Contingent - DNA |
acollow
removed
the
Contingent - DNA
pcolarco
added
Non 0-diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entries for energy, non-energy, and shipping emissions have been removed from the ExtData.yaml files for carbon, sulfate, and nitrate as these enter through HEMCO. This change must be pulled in at the same time as a PR in GEOSChem_GridComp. The changes are not fully 0 diff however the difference in the emissions when piped through HEMCO instead of entering through GOCART is within the range of uncertainty and below the non-conservative nature of the daily temporal interpolation. This PR must be take alongside GEOS-ESM/GEOSchem_GridComp#300 to ensure emissions are not double counted or missing.