Skip to content

Initial attempt at supportind DTIO for aspects #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tclune wants to merge 1 commit into
base: release/MAPL-v3
Choose a base branch
from
Open

Initial attempt at supportind DTIO for aspects #3304

tclune wants to merge 1 commit into from

Conversation

@tclune
Copy link
Collaborator

@tclune tclune commented Jan 12, 2025

Already ran into some runtime issues with NAG. But workaround is in place.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@tclune
Initial attempt at supportind DTIO for aspects
174d84b 
Already ran into some runtime issues with NAG.  But
workaround is in place.
@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jan 12, 2025
@tclune tclune requested a review from a team as a code owner January 12, 2025 20:19
@tclune tclune requested a review from pchakraborty January 12, 2025 20:19
mathomp4
mathomp4 reviewed Jan 13, 2025
View reviewed changes
generic3g/connection/SimpleConnection.F90
end if
end do

_HERE, src_registry
Copy link
Member

@mathomp4 mathomp4 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_HERE, src_registry

I'm guessing the _HERE can be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathomp4 mathomp4 mathomp4 left review comments

@pchakraborty pchakraborty Awaiting requested review from pchakraborty

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tclune @mathomp4