Skip to content

Conversation

@aoloso
Copy link
Contributor

@aoloso aoloso commented Nov 25, 2025

Added changes to get profiler to work with threads and test to check that. Only the master thread is capturing elapsed times.

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

Closes #4207

…that. Only the master thread is eporting elapsed times
@aoloso aoloso requested a review from a team as a code owner November 25, 2025 16:44
@aoloso aoloso added the 🪲 Bugfix This fixes a bug! label Nov 25, 2025
tclune
tclune previously approved these changes Nov 25, 2025
@mathomp4
Copy link
Member

Hmm. ifx is complaining about:

 5/85 Test  #10: Profiler_Demo_Hybrid .............***Failed    1.32 sec
 First sum rank, thread            0           0  of            4  threads: 
   4999757.    
 First sum rank, thread            0           2  of            4  threads: 
   5000719.    
forrtl: severe (151): allocatable array is already allocated
Image              PC                Routine            Line        Source             
hybrid_demo.x      0000000000432428  Unknown               Unknown  Unknown
hybrid_demo.x      000000000042B3D3  main_IP_do_lap_.D         223  hybrid_demo.i90
libiomp5.so        00007FD898150603  __kmp_invoke_micr     Unknown  Unknown
libiomp5.so        00007FD8980D0FB3  Unknown               Unknown  Unknown
libiomp5.so        00007FD8980CFCAE  Unknown               Unknown  Unknown
libiomp5.so        00007FD898151B22  Unknown               Unknown  Unknown
libc.so.6          00007FD897A61AA4  Unknown               Unknown  Unknown
libc.so.6          00007FD897AEEA64  __clone               Unknown  Unknown

While ifort is saying:

 5/85 Test  #10: Profiler_Demo_Hybrid .............***Failed    2.73 sec
 First sum rank, thread            0           1  of            4  threads: 
   5000450.    
 First sum rank, thread            0           3  of            4  threads: 
   5000402.    
 First sum rank, thread            0           0  of            4  threads: 
   5000657.    
 First sum rank, thread            0           2  of            4  threads: 
   4999522.    
 Second sum rank, thread            0           1  of            4  threads: 
   393629.1    
forrtl: error (182): floating invalid - possible uninitialized real/complex variable.
Image              PC                Routine            Line        Source             
libc.so.6          00007F59DFA33320  Unknown               Unknown  Unknown
hybrid_demo.x      00000000004304A5  main_IP_do_lap_           189  hybrid_demo.F90
libiomp5.so        00007F59DFD36C43  __kmp_invoke_micr     Unknown  Unknown
libiomp5.so        00007F59DFCC5273  Unknown               Unknown  Unknown
libiomp5.so        00007F59DFCC3CEE  Unknown               Unknown  Unknown
libiomp5.so        00007F59DFD37DE1  Unknown               Unknown  Unknown
libc.so.6          00007F59DFA8AA94  Unknown               Unknown  Unknown
libc.so.6          00007F59DFB17A34  __clone               Unknown  Unknown

@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jan 5, 2026
@mathomp4 mathomp4 mentioned this pull request Jan 5, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants