-
Notifications
You must be signed in to change notification settings - Fork 7
Add eva comparison plots for observations #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…a.gov:/home/manstett/swell-main into feature/mranst/eva_comparison_obs
…a.gov:/home/manstett/swell-main into feature/mranst/eva_comparison_obs
…a.gov:/home/manstett/swell-main into feature/mranst/eva_comparison_obs
|
Some plots that came to my mind is that 1) two different experiments could be on the same scatter plot, with x-axis exp 1 ombg and y-axis exp2 ombg (or any other IODA groups), 2) Similar to the increment differences there could be difference plots of ombg and oman with 3 map panels (exp1 ombg, exp2 ombg and difference). However I would think the better approach would be the different groups and applications figure out what type of plots they would want to create. For instance Megan can take a look at some of these EVA YAMLs (with our guidance nonetheless) and modify them accordingly. Otherwise I think this is a strong enough foundation, I haven't done a full review sweep though. Regarding this PR, does the EVA yaml containing |
It finds the overlapping cycles automatically (though they can be manually specified). The eva yamls are differentiated by suite right now in swell, so I carried over that convention and changed the file name to distinguish them. We could potentially split up the compare suite, which is located in one directory right now, and have individual ones for each suite |
|
I've added obs plots for |
|
This is looking really good. I only have minor suggestions:
The suggestions above aim at reducing the number of plots generated - good for i-node count - but also for user sanity: the figs we have the harder it gets to look at them all. |
|
I've reduced the number of plots under the jedi_log task, so they just display the information on one panel. By default, the experiment listed first will be referred to as 'CTL', and the second as 'EXP', I also added the ability to set custom tags to refer to experiments instead. You can now specify a dictionary to set these |
| - type: LinePlot | ||
| label: 'jb' | ||
| x: | ||
| variable: JediLogTest::convergence::total_iteration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comment while testing, this task failed for me so I noticed for marine tasks data collection is jedi_log_test not JediLogTest. Sorry, this is annoying.
At some point we can make geos_cf, atm and marine consistent but that is not relevant for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the cost functions work differently for marine as well? I see jb and jojc isn't a variable in the dataset
| - type: LinePlot | ||
| label: 'jb' | ||
| x: | ||
| variable: JediLogTest::convergence::total_iteration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto




This PR adds comparison type plots for
3dfgat_atmosand3dfgat_cycle. Any plot generated by the regularEvaObservationstask is plotted in the same figure for two different experiments. I could use some help knowing how to handle the 'difference' aspect of the plots, for a lot of these I think a straight up difference isn't going to make much sense. We could handle it by plotting both sets on the same graph, but some of these plots are so dense that it probably isn't going to be legible