Skip to content

Conversation

@tomudding
Copy link
Member

Description

We have repeatedly encountered inconsistencies in ReportDB (which is the materialised view of GEWISDB) where remnants of annulled decisions remained visible. A common example was bodies that were founded during a board switch and later annulled but still appear in ReportDB because the body entity itself was
never removed.

In the past we have always solved this by converting the original decision (the one being annulled) to a textual decision, effectively preventing the body (or other entity) from being created.

This commit introduces a robust annulment mechanism for decisions and their subdecisions. This new functionality explicitly reverts or removes each subdecision type, ensuring that annulments leave no residual state in ReportDB.

Related issues/external references

Fixes ABC-2411-508.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

@tomudding
Copy link
Member Author

A draft, because there are some issues that I have not solved:

  1. Niet mogelijk om orgaan op te heffen #507 (not because of my changes - present on main)
  2. deleting an annulment does not bring back OrganMembers because the Installation subdecisions get removed when creating the annulment
  3. it is possible to Discharge then Annul then Discharge then deleting the Annul leaving the database is an inconsistent state (possibly caused by issue 2)

Ideally, we also fix GH-283 in this.

@tomudding tomudding force-pushed the feature/reverse-original-decision-by-annulment branch from 323326a to 5affe37 Compare December 1, 2025 17:01
@tomudding
Copy link
Member Author

Found the cause of issue 2: GH-227. However, that should be fixed by properly going backwards through the subdecisions.

@tomudding tomudding force-pushed the feature/reverse-original-decision-by-annulment branch from 5affe37 to 7416f17 Compare December 1, 2025 18:48
We have repeatedly encountered inconsistencies in ReportDB (which is the
materialised view of GEWISDB) where remnants of annulled decisions remained
visible. A common example was bodies that were founded during a board switch and
later annulled but still appear in ReportDB because the body entity itself was
never removed.

In the past we have always solved this by converting the original decision (the
one being annulled) to a textual decision, effectively preventing the body (or
other entity) from being created.

This commit introduces a robust annulment mechanism for decisions and their
subdecisions. This new functionality explicitly reverts or removes each
subdecision type, ensuring that annulments leave no residual state in ReportDB.
@tomudding tomudding force-pushed the feature/reverse-original-decision-by-annulment branch from 7416f17 to 86e660a Compare December 1, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant