Skip to content

Merge RBMDataSet and RBMDataSetElPaso into unified class #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sahiljhawar merged 24 commits into from
Nov 4, 2025
Merged

Merge RBMDataSet and RBMDataSetElPaso into unified class #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b6f08c9
Initial plan
Copilot Oct 28, 2025
5c99ac0
Merge RBMDataSet and RBMDataSetElPaso functionality into single RBMDa…
Copilot Oct 28, 2025
822fa2e
Remove RBMDataSetElPaso.py and update all imports
Copilot Oct 28, 2025
fea0619
Run linters and format code
Copilot Oct 28, 2025
4a2b5d3
new exception for RBMDS
sahiljhawar Oct 29, 2025
0e3d46c
remove elpaso enum and add dummy enum
sahiljhawar Oct 29, 2025
d021c95
add new imports
sahiljhawar Oct 29, 2025
6a1617f
new exception for RBMDS
sahiljhawar Oct 29, 2025
220e295
refactor: RBMDataSet to use VariableLiteral and improve error handling
sahiljhawar Oct 29, 2025
c672e0a
Update tests to match refactored RBMDataSet implementation
Copilot Oct 29, 2025
4044cfd
Merge test_RBMDatasetElPaso.py into test_RBMDataset.py
Copilot Oct 29, 2025
edc06a9
test: Replace hardcoded enums with DummyEnum in RBMDataSet tests
sahiljhawar Oct 29, 2025
0d7257c
refactor: Add get_loaded_variables method and improve __eq__ comparison
sahiljhawar Oct 29, 2025
4ebd597
refactor: only use get_loaded_variables to compare objects
sahiljhawar Oct 29, 2025
7f3519a
tests: add tests for __eq__ method
sahiljhawar Oct 29, 2025
06a34b1
remove mentions of elpaso
sahiljhawar Oct 29, 2025
ee5295c
add enable_dict_loading i.e., optionally allow dict loading when load…
sahiljhawar Oct 29, 2025
3901c03
fix type annotation
sahiljhawar Oct 30, 2025
2b31188
add .env to gitingore
sahiljhawar Oct 30, 2025
cbb89fb
return object in update_from_dict
sahiljhawar Oct 30, 2025
17b533e
Removed Dummy enum. Small type changes.
Oct 30, 2025
68a7e70
ruff formatting and fixes
sahiljhawar Oct 30, 2025
e253b77
add icecream to reqs
sahiljhawar Oct 30, 2025
2c8878c
source .env when building docs locally
sahiljhawar Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ cron_check.sh
swace_commented_code
docs/_build/*
docs/api/*
.nfs*
.nfs*
.env
3 changes: 3 additions & 0 deletions docs/makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
#

# You can set these variables from the command line.
ifneq (,$(wildcard $(PWD)/../.env))
include $(PWD)/../.env
endif
SPHINXOPTS =
SPHINXBUILD = sphinx-build
PAPER =
Expand Down
4 changes: 3 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,6 @@ wget
distance
tqdm
pytest-mock
netcdf4
netcdf4
icecream

Loading