fix(wasm-x-secp256k1): make all secp256k1 versions used converge to 0.27 #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightning still fails compilation miserably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades multiple dependencies so that they all land on using secp v0.27.
The problem with wasm duplicate symbol issue started when
rust-bitcoinwas added to wasm as a dependency (for WalletConnect PSBT work), which caused pulling secp v0.24 while we already use secp v0.20. Such co-existence of both versions upsets the linking process in wasm.For native, this seems to be a non-issue, as we have been using secp v0.20 and secp v0.24 at the same time without any linking problems.
This PR upgrades secp to v0.27 and a couple of other deps to have them land on using secp v0.27 in their dep tree as well. (v0.27 being the least common factor between all the deps that we have that use secp, as some deps skipped v0.24, v0.25, v0.26, and a downgrade to v0.20 was also not possible because some deps didn't use it).
This PR also feature-gates lightning behind
enable-lightningflag to facilitate testing whether compilation issues resolve or not without having 100+ errors on the terminal. Right now though, lightning is still broken :/