fix(TPU): add trade fee estimation for TPU code #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dimxy wants to merge 45 commits into dev from refactor-TPU-fee-calc

Collaborator

dimxy commented Sep 23, 2025 •

edited

Loading

Before this PR, the legacy swap functions were used to estimate trade fees (tx fees) for TPU swaps, so those estimations may not have been quite accurate.

This PR adds trade fee estimation functions for TPU swap steps (like send taker funding, spend taker funding, send maker payment etc).

As refactoring, a new SwapTotalFeeHelper trait is added to abstract getting fees for balance checking in swaps.

TODO: add more tests to validate taker and maker max_volume/trade_preimage estimations for TPU swap fee estimations added in this PR.

dimxy added 25 commits

September 20, 2025 22:59


          add support for trade fee estimation specific for TPU

c477e96


          fix fmt

0c064fe


          fix wasm clippy

87df052


          rename to check_balance_for_swap used for both maker and taker

f5314e0


          fix check and fmt

20a3684


          add doc comment to new trait

efc9643


          fix paid_from_trading_vol in fee_helper

fd43de6


          fix legacy taker swap preimage value in SwapTotalFeeHelper

0fb360f


          fix clippy

303c02c


          fix base/rel in swap fee_helper

b638da7


          fix(fee_helper): proper trade amount, proper check for plaform coin f…

…ee, use non zero address, add funding spend fee


          fix paid_from_trading_vol in updated check_balance_for_swap

ad0202d


          use gas_limit const to get taker funding fee


          fix(fee_helper): handle DexFee::NoFee

e51838d


          fix clippy


          use fee_helper in taker_swap_v2 start

17a7747


          fix(fee_helper): use TPU fees with check_other_coin_balance_for_swap …

c49542f

…fn as well


          fix(tests, fee_helper): update test expected for refund fee

f94eb60


          fix(tests): more expected amount fixes

61c7011


          fix(tests): another expected amount fix

c3654d8


          use fee_helper (supporting legacy and TPU) to calc max vol

a22a9c4


          revert debug colors

efcd482


          fix is_platform_coin cond

812c8fc


          add stage to TPU fee estimate fn's

c7ba804


          fix(tests): ignore failing coins tests

ab69f7b

dimxy self-assigned this

dimxy added the improvement: swap label

dimxy added 3 commits

September 23, 2025 22:42


          revert log colors

d6b88a3


          fix(tests): add timeout in qrc20 test

b084c29


          fix update_maker_order broken in fee_helper refactoring

446b229

dimxy added 2 commits

October 9, 2025 13:11


          Merge branch 'dev' into refactor-TPU-fee-calc

3ab7dc0

* dev:
  fix(TPU): correct dexfee in check balance to prevent swap failures (#2600)
  fix(tests): fix/remove kmd rewards failing test (#2633)
  chore(ci): bump CI container image to debian bullseye-slim to match dev (#2641)
  chore(release): add changelog entries for v2.5.2-beta (#2639)
  chore(release): bump mm2 version to 2.5.2-beta (#2638)
  feat(ci): add macos universal2 build (#2628)
  fix(metrics): remove memory_db size metric (#2632)
  fix(zcoin): exact-anchor witnesses in wasm get_spendable_notes (#2629)
  fix(evm-swapv2): no mempool inclusion required for maker payment validation (#2618)
  chore(rust 1.90): make CI clippy/fmt pass
  Revert "fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580)"
  Revert "fix(orderbook): validate roots before commit (#2605)"


          fix clippy wasm

e4a014d

Collaborator Author

dimxy commented Oct 9, 2025

Conflicts resolved,
PR is ready for review

dimxy marked this pull request as draft

October 9, 2025 12:05

Collaborator Author

dimxy commented Oct 9, 2025

Conflicts resolved, PR is ready for review

One important test fails. To draft for now..


          fix(trade_fee): use gas limit const for TPU maker payment (instead of…

68d1fd0

… fake swap values which did not work w/o token approval first)

Collaborator Author

dimxy commented Oct 10, 2025 •

edited

Loading

Conflicts resolved, PR is ready for review

One important test fails. To draft for now..

Looks like tests are okay now.

I saw once failure of test_update_maker_order in a CI workflow run (which is worrying). I ran this test multiple times on my PC and a VPC but the failure never repeated itself. I noticed that when the failed test was running the RICK coin balance was unusual (so it may be some activity in the chain affected the test results).
I tried this test with different balances, including the one from the failed test, but all runs were okay.

So I am converting the PR to ready now.

dimxy marked this pull request as ready for review

October 10, 2025 08:42


          add note about test failure reason

393a4e6

mobias17 mentioned this pull request

[FR] trade_preimage despite 0 holdings #2619

Open

shamardy added 2.7.0-beta and removed 2.6.0-beta labels

github-actions bot commented Nov 30, 2025

@shamardy
Please review it again.

github-actions bot added the [] label

shamardy removed the [] label

github-actions bot commented Dec 3, 2025

@shamardy
Please review it again.

github-actions bot added the [] label

github-actions bot commented Dec 5, 2025

@shamardy
Please review it again.

shamardy removed the [] label

github-actions bot commented Dec 11, 2025

@shamardy
Please review it again.

github-actions bot added the [] label

github-actions bot commented Dec 13, 2025

@shamardy
Please review it again.

8 similar comments

github-actions bot commented Dec 17, 2025

@shamardy
Please review it again.

github-actions bot commented Dec 19, 2025

@shamardy
Please review it again.

github-actions bot commented Dec 23, 2025

@shamardy
Please review it again.

github-actions bot commented Dec 25, 2025

@shamardy
Please review it again.

github-actions bot commented Dec 27, 2025

@shamardy
Please review it again.

github-actions bot commented Dec 31, 2025

@shamardy
Please review it again.

github-actions bot commented Jan 2, 2026

@shamardy
Please review it again.

github-actions bot commented Jan 6, 2026

@shamardy
Please review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.7.0-beta improvement: swap []