refactor(ci): split docker tests into feature-gated parallel suites #2707

shamardy · 2025-12-16T16:39:46Z

Summary

Splits the monolithic docker test suite into isolated, feature-gated test modules that run in parallel CI jobs. This refactor enables:

Faster CI feedback — Tests run in parallel instead of sequentially (~4x faster total)
Selective local testing — Run only the tests you need during development
Docker-compose support — Containers can be reused across test runs for faster iteration
WASM/cross-platform testing readiness — The compose infrastructure can be adapted for browser-based WASM tests or other platforms that can't use testcontainers
Future Electrum testing — The docker-compose infrastructure enables adding dockerized Electrum servers alongside full nodes (see Dockerize Electrum servers and migrate tests from remote Electrums #2708)

Features Added

Feature	Purpose	Containers
`docker-tests-eth`	ETH/ERC20/NFT tests	Geth
`docker-tests-slp`	BCH/SLP token tests	FORSLP
`docker-tests-sia`	Sia tests + DSIA swaps	Sia + UTXO
`docker-tests-ordermatch`	Orderbook/matching tests	UTXO
`docker-tests-swaps`	Swap protocol tests	UTXO
`docker-tests-watchers`	UTXO watcher tests	UTXO
`docker-tests-watchers-eth`	ETH watcher tests (unstable)	UTXO + Geth
`docker-tests-qrc20`	Qtum/QRC20 tests	Qtum + UTXO
`docker-tests-tendermint`	Cosmos/IBC tests	Cosmos
`docker-tests-zcoin`	ZCoin/Zombie tests	Zombie
`docker-tests-integration`	Cross-chain swaps	ALL
`docker-tests-all`	All suites (local dev)	ALL

Key Changes

New CI workflow — Matrix-based docker test jobs in .github/workflows/test.yml
Docker-compose infrastructure — .docker/test-nodes.yml with profile-based container selection
Test module reorganization — Feature-gated modules in tests/docker_tests/
Helper refactoring — Split helpers by chain type (helpers/eth.rs, helpers/utxo.rs, helpers/slp.rs, etc.)
Runner extraction — Per-chain setup modules in runner/ directory
Image migration — Docker images migrated to gleec organization

Related Issues

Closes:

split docker tests by protocol #2417 — Split docker tests by protocol
Refactor docker_tests module structure after QRC20 native integration. #764 — Refactor docker_tests module structure after QRC20 native integration

Partially addresses:

migrating personal account images to organization account #2381 — Migrating personal account images to organization account (moved to gleec org)
Speed up tests and make them more reliable. #835 — Speed up tests and make them more reliable (parallel execution)
Permission denied error when starting docker tests #2388 — Permission denied error when starting docker tests (proper volume management)
Update Utxo docker node #2231 — Update Utxo docker node (now using gleec/testblockchain:multiarch)

Enables:

Dockerize Electrum servers and migrate tests from remote Electrums #2708 — Dockerize Electrum servers and migrate tests from remote Electrums

Flaky Tests Ignored

Temporarily ignored tests that depend on external infrastructure:

Electrum tests (Unit/Integration):

Remote Electrum servers are unreliable; tracked in #2708 comment

Orderbook sync test (Integration):

Timing-dependent test; tracked in PR #2626 comment

NFT tests (Unit/WASM):
External API tests converted from cross_test! to native-only with #[ignore]. The cross_test! macro always generates WASM tests even with cfg restrictions, causing CI failures when external APIs are unavailable.

test_moralis_requests — Moralis API rate-limited (401 Unauthorized)
test_antispam_scan_endpoints — nft-antispam.gleec.com unavailable
test_camo — nft-antispam.gleec.com unavailable (was already macos/windows only)

Run manually with: cargo test <test_name> -- --ignored

Test Plan

All 12 docker test features pass cargo clippy cleanly
CI jobs run in parallel with correct container profiles
Verify each test suite passes in CI (monitor after merge)
Local docker-compose workflow tested (KDF_DOCKER_COMPOSE_ENV=1)

Review Plan

Quick scan (file moves, no logic changes)

Files were moved/reorganized without logic changes. These can be skimmed:

Test extraction: utxo_swaps_v1_tests.rs, utxo_ordermatch_v1_tests.rs, eth_inner_tests.rs, tendermint_swap_tests.rs
Helper splits: content moved between helpers/*.rs files

Focus areas for detailed review

1. CI/Infrastructure (most important)

.github/workflows/test.yml — New matrix job structure and profile mapping
.docker/test-nodes.yml — Container definitions and health checks
scripts/ci/docker-test-nodes-setup.sh — Runtime setup for Cosmos/Sia nodes

2. Test module structure

tests/docker_tests/mod.rs — Feature gates and module organization
tests/docker_tests/runner/mod.rs — Test runner and setup dispatch
tests/docker_tests/runner/*.rs — Per-chain setup modules

3. Helper organization

tests/docker_tests/helpers/mod.rs — Feature gate mapping
tests/docker_tests/helpers/env.rs — Shared environment (DockerNode, service constants)
tests/docker_tests/helpers/docker_ops.rs — CoinDockerOps trait

4. Feature flags

mm2src/mm2_main/Cargo.toml — Feature definitions and dependencies

What NOT to focus on

Line-by-line review of moved test code (unchanged logic)
Detailed review of existing test implementations

🤖 Generated with Claude Code

Add docker-compose based infrastructure to enable sharing test nodes across multiple test commands within a single CI job or local session. Phase 1 implementation includes: - .docker/test-nodes.yml: Docker Compose file defining all 10 test blockchain nodes (MYCOIN, MYCOIN1, FORSLP, QTUM, GETH, ZOMBIE, NUCLEUS, ATOM, IBC-RELAYER, SIA) with health checks and profiles - scripts/ci/docker-test-nodes-setup.sh: Setup script that prepares container runtime directories and Sia configuration files - docs/DOCKER_TESTS.md: Documentation for docker test infrastructure - Updated .github/workflows/test.yml to run setup script Profiles allow selective node startup: - utxo, slp, qrc20, evm, zombie, cosmos, sia, all Environment variables for future compose mode: - KDF_DOCKER_COMPOSE_ENV=1: Attach to running containers - KDF_DOCKER_ENV_STATE_FILE: Load metadata, skip initialization This is groundwork for Phase 2 which will modify the test harness to support the compose mode and metadata persistence. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Implement Phase 2 of docker node sharing: refactor the test harness to support three execution modes: 1. Testcontainers (default): Start containers, run init - existing behavior 2. ComposeInit (KDF_DOCKER_COMPOSE_ENV=1): Attach to running containers, run initialization, save metadata for reuse 3. ReuseMetadata (KDF_DOCKER_ENV_STATE_FILE=path): Load metadata from file, skip both container start and initialization This enables efficient development workflows where nodes only need to be initialized once per docker-compose session, with subsequent test runs reusing the already-initialized state. Key changes: - Add docker_env_metadata.rs: Serializable metadata structs for all node types (UTXO, Qtum/QRC20, SLP, Geth/ERC20/NFT, Cosmos, Zombie, Sia) - Refactor docker_tests_runner() to support all three modes - Add helper functions for compose mode: setup_qtum_conf_for_compose(), prepare_ibc_channels_compose(), wait_until_relayer_container_is_ready_compose() - Fix unused import warning in eth_docker_tests.rs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add environment variables required by testblockchain image for UTXO test nodes (mycoin, mycoin1, forslp). These match the variables set by testcontainers in docker_tests_common.rs: - CHAIN: Chain identifier (MYCOIN, MYCOIN1, FORSLP) - COIN: Coin type (Komodo) - DAEMON_URL: Internal daemon URL - TEST_ADDY: Pre-funded test address - TEST_WIF: Corresponding private key - TEST_PUBKEY: Public key for test transactions Without these variables, containers crash with KeyError during startup. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

When reusing metadata (KDF_DOCKER_ENV_STATE_FILE mode), validate that all initialized nodes are reachable before proceeding with tests. This fails fast with a clear error message if containers are not running, rather than failing cryptically during test execution. Health checks performed: - UTXO nodes: TCP connect to MYCOIN/MYCOIN1 ports - Qtum: TCP connect to RPC port - SLP: TCP connect to FORSLP port - Geth: web3 eth_blockNumber RPC call - Zombie: TCP connect to RPC port - Cosmos: TCP connect to Nucleus/Atom RPC ports - Sia: TCP connect to walletd port 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Update docker-tests workflow job to: - Start all test nodes via docker-compose before running tests - Use KDF_DOCKER_COMPOSE_ENV=1 to attach to compose containers - Stop containers after tests (runs even if tests fail) This enables faster test iterations and better visibility into container state. Future work can add multiple test binaries sharing the same nodes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

- Update CI Integration section to reflect docker-compose workflow - Add new Execution Modes section explaining the three modes: - Testcontainers (default): fresh containers per run - ComposeInit: attach to compose containers, save metadata - ReuseMetadata: load metadata, skip initialization - Document mode selection logic and health checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

- Add `docker-tests-slp` feature flag to mm2_main/Cargo.toml - Guard slp_tests module with #[cfg(feature = "docker-tests-slp")] - Move SLP-specific helpers from docker_tests_common.rs to slp_tests.rs - Add docker-tests-slp CI job that only starts FORSLP container 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

When running docker tests with only the SLP node (FORSLP), the test harness attempts to initialize all other node types (MYCOIN, QTUM, etc.) which aren't running, causing the tests to fail. Add environment variables to skip the nodes that aren't part of the SLP test job. This allows the SLP tests to run independently with only the FORSLP node. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

In docker-compose mode, the coin daemon config files exist only inside the containers, not on the host. The test harness needs these files to initialize coin instances for testing. Add setup_utxo_conf_for_compose() function that copies the config file from the running container to the expected host location before initializing the coin. This fixes SLP tests (FORSLP) and UTXO tests (MYCOIN, MYCOIN1) when running with docker-compose. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add cargo test filter `-- slp_tests::` to ensure only SLP tests run in the docker-tests-slp CI job. Previously, all 243 docker tests were executing because the docker-tests-slp feature only guarded the slp_tests module compilation, but other test modules still compiled since they only require run-docker-tests. Also documents the split CI job structure and future refactoring plan for modularizing docker_tests_common.rs into chain-specific helper modules with per-chain feature flags. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

The SLP trade tests (trade_test_with_maker_slp, trade_test_with_taker_slp) require both FORSLP and QTUM nodes to run. They were failing in the docker-tests-slp CI job which only starts the FORSLP node. - Create swap_tests.rs for cross-chain swap tests - Move trade tests from slp_tests.rs to swap_tests.rs - Gate swap_tests with run-docker-tests but NOT docker-tests-slp - This ensures cross-chain tests only run in the main docker-tests job 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

The docker-compose volume paths were incorrectly using ./.docker/container-runtime as the default, but since the compose file is in .docker/, this resolved to .docker/.docker/container-runtime which doesn't exist. Fix the default paths to ./container-runtime (relative to the compose file location in .docker/). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

The Cosmos container images (nucleusd, gaiad) are minimal scratch-based images without /bin/sh, so CMD-SHELL healthchecks always fail. This caused ibc-relayer to never start due to depends_on: service_healthy. Solution: - Remove healthcheck definitions from nucleus and atom services - Change ibc-relayer depends_on to use service_started instead This aligns compose mode with Testcontainers mode which has no healthchecks - the test harness handles readiness via prepare_ibc_channels_compose and wait_until_relayer_container_is_ready. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add docker-tests-sia feature and CI job following the SLP split pattern: - Add `docker-tests-sia` feature to Cargo.toml (depends on run-docker-tests) - Gate `sia_docker_tests` module with `#[cfg(feature = "docker-tests-sia")]` - Exclude Sia tests from main docker-tests job via swap_tests guard - Add dedicated `docker-tests-sia` CI job that: - Starts only the Sia docker profile - Sets _KDF_NO_* env vars to skip other node initializations - Runs only sia_docker_tests:: tests All 5 Sia tests are single-chain (RPC client tests against localhost:9980): - test_sia_new_client, test_sia_client_bad_auth, test_sia_client_consensus_tip - test_sia_client_address_balance, test_sia_client_build_tx This reduces CI resource usage by running Sia tests in isolation with only the Sia container, rather than starting all test nodes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

In compose mode, the ZOMBIE.conf file needs to be copied from the container before ZCoinAssetDockerOps::new() can initialize the coin. This was missing, causing tests to fail with: "Error parsing the native wallet configuration '~/.komodo/ZOMBIE/ZOMBIE.conf': No such file or directory" This mirrors how other UTXO coins (FORSLP, MYCOIN, etc.) handle config copying in compose mode using setup_utxo_conf_for_compose(). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

The Sia walletd container requires -network=/config/ci_network.json to enable the custom test network with mining support. This was already present in testcontainers mode but missing from docker-compose. Also add a common pitfall to AGENTS.md about checking the correct base branch when comparing changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

The test was mining only 10 blocks but with maturityDelay=10 in the test network, those coins aren't visible in the balance yet. Increase to 15 blocks so that the first 5 blocks' rewards will be mature. This makes the test self-sufficient and not dependent on other tests or background miners running concurrently. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…avior The sia-data volume was causing the address indexer to lag behind consensus in compose mode. By using ephemeral storage (like testcontainers does), each run starts fresh and the indexer stays in sync. Also revert the test back to original 10 blocks since fresh state fixes the issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Add reminders to run cargo fmt and clippy before committing: - cargo fmt is required (CI fails on unformatted code) - clippy should target changed crates for speed - include feature flags if code uses them - run with wasm32 target if WASM code changed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

Adds logging to wait_for_dsia_node_ready() to track: - When mining starts - Current height after mining completes This will help diagnose why test_sia_client_address_balance fails in CI but passes locally.

The test_sia_client_address_balance test was failing in CI because the address indexer needs time to process new addresses when tests run in parallel. Added a 100ms delay after mining to allow the indexer to catch up before querying the balance. Also added debug logging to wait_for_dsia_node_ready() to help diagnose any future initialization issues.

- Add docker-tests-eth feature flag to Cargo.toml - Add docker-tests-eth CI job (60 min timeout, evm profile) - Extract shared ETH helpers to helpers/eth.rs module - Update imports in dependent test modules - Feature-gate eth_docker_tests module - Update docs/DOCKER_TESTS.md with ETH mapping - Add root CLAUDE.md reference note to all crate AGENTS.md files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…ocker_tests - Add eth_coin_with_random_privkey_using_urls to helpers::eth import - Remove unused imports: GETH_NFT_MAKER_SWAP_V2, checksum_address, ERC20_ABI, DerivationMethod, TransactionRequest - Remove duplicate fill_eth_erc20_with_private_key function 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

- Move ERC721_TEST_ABI and ERC1155_TEST_ABI from docker_tests_common - Move maker_swap_v2, taker_swap_v2, geth_nft_maker_swap_v2, geth_erc721_contract, geth_erc1155_contract to eth_docker_tests - Keep only shared helpers in helpers/eth.rs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

…d CI split

The test_two_watchers_spend_maker_payment_eth_erc20 test had meaningless assertions that compared values to themselves (always true). Replace with a proper assertion that verifies exactly one watcher receives the reward when two watchers race to spend the maker payment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace hardcoded GETH_WEB3 static with a dynamically constructed Web3 instance using the RPC URL from DockerEnvMetadata. This ensures the health check validates connectivity to the actual Geth node specified in metadata rather than always checking the default localhost:8545 endpoint. - Add web3 import for Http transport and Web3 types - Create local Web3 instance from metadata.geth.rpc_url in validate_nodes_health() - Add clear error message when Geth metadata is missing - Include RPC URL in log and error messages for easier debugging 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Replace temp_dir() with coin_daemon_data_dir("qtum", false) for Qtum config path in compose mode. This ensures the config file persists across test runs, enabling proper metadata reuse in ReuseMetadata mode. Changes: - Use coin_daemon_data_dir("qtum", false) instead of temp_dir() in setup_qtum_conf_for_compose() - QTUM is an independent blockchain, not a Komodo asset chain, so is_asset_chain=false is correct - Add conf_path existence check in validate_nodes_health() for Qtum - Return clear error message when config is missing (stale metadata) The stable path on Linux is ~/.qtum/qtum.conf, matching the standard Qtum daemon data directory. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Add `get_or_default_metadata_path()` as the single source of truth for where metadata should be saved. This function returns the env var path if `KDF_DOCKER_ENV_STATE_FILE` is set, otherwise the default path. ComposeInit now uses this centralized function when saving metadata, allowing users to specify a custom save location via the env var. ReuseMetadata mode behavior remains unchanged (still gated by env var). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Validate that all contract addresses in metadata have deployed bytecode, catching stale metadata where Geth containers were recreated but contracts weren't re-deployed. Checks: erc20, swap, maker/taker_swap_v2, watchers, erc721, erc1155, and nft_maker_swap_v2 contracts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The error message format was changed in extract_secret but the test assertion wasn't updated to match. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Brings endpoint migration from #2704 (moralis/antispam/prices endpoints moved to gleec.com)

The test was asserting that specific addresses are marked as spam (true), but external blocklist data changes over time. Changed assertions to only verify that the API returns data for the queried addresses/domains, without depending on their specific spam/phishing status. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Temporarily ignore tests that depend on remote Electrum servers (tracked in #2708) and orderbook sync timing (tracked in PR #2626). Unit tests ignored (Electrum): - test_unavailable_electrum_proto_version - test_one_unavailable_electrum_proto_version - test_qtum_add_delegation - test_qtum_get_delegation_infos - test_wait_for_confirmations_excepted Integration tests ignored (Electrum): - test_electrum_tx_history - test_add_delegation_qtum - test_query_delegations_info_qtum - test_qrc20_withdraw Integration test ignored (orderbook sync): - test_order_cancellation_received_before_creation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

…k header test The `test_block_header_utxo_loop` test was flaky because it used fixed `Timer::sleep()` calls that weren't sufficient under CI load. Under heavy load, only 2 chunks completed instead of 4, leaving height at 9 instead of 14. Replace fixed sleeps with `repeatable!` macro-based polling that waits until the target height is reached and all expected mock steps are consumed. Uses 100ms poll interval with 30-second timeout. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Update btc_with_sync_starting_header() from height 764064 (Nov 2022) to height 872928 (Dec 2024). This reduces the block header sync from ~112,000 headers to ~3,000-4,000, fixing timeout failures on Windows CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

mariocynicys

maybe we wanna remove utxo from docker-tests-swaps-utxo.

.docker/test-nodes.yml

mm2src/mm2_main/tests/docker_tests/helpers/env.rs

.github/workflows/test.yml

docs/DOCKER_TESTS.md

.docker/test-nodes.yml

mariocynicys

cosmos docker env doesn't bootup on macos. looks like it has to do with the image arch not being available for arm m1.

.docker/test-nodes.yml

.github/workflows/test.yml

Rename feature flag to reflect that swap protocol tests are coin-agnostic (they use UTXO as test substrate but test protocol logic that works across all coin types). Also reorganize Cargo.toml feature comments to clarify test categories: - Chain-specific tests: Test coin implementations per blockchain - Protocol tests: Test cross-cutting functionality (swaps, ordermatch, watchers) - Cross-chain integration tests: Test interactions between chain families 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shamardy · 2025-12-31T05:42:26Z

cosmos docker env doesn't bootup on macos. looks like it has to do with the image arch not being available for arm m1.

The Cosmos images were already amd64-only before the migration - this isn't new.

I never noticed this because I use Docker Desktop, which runs them via Rosetta emulation automatically (you might see a platform warning but they work). If they're failing for you, check Docker Desktop → Settings → General → "Use Rosetta for x86_64/amd64 emulation on Apple Silicon" is enabled.

Building native arm64 images would be a separate effort if needed.

…ative Convert NFT tests that depend on external APIs from cross_test! macro to native-only tests with #[ignore] attribute. The cross_test! macro always generates WASM tests even with cfg restrictions, causing CI failures when external APIs are unavailable. Tests excluded from WASM and ignored on native: - test_moralis_requests: Moralis API rate-limited (401 Unauthorized) - test_antispam_scan_endpoints: nft-antispam.gleec.com unavailable - test_camo: nft-antispam.gleec.com unavailable (was already macos/windows only) These tests can be run manually with: cargo test <test_name> -- --ignored 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

These volumes were artifacts from the removed ReuseMetadata mode (removed in 753fc5d). Tests use ephemeral storage like testcontainers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

…e_container_id Docker-compose always adds the com.docker.compose.service label, so the container name fallback would never trigger.

Fee/balance can change slightly between the my_balance/trade_preimage calls and the update_maker_order call, causing flaky test failures.

Tendermint tests only need Cosmos node setup, not Sia config.

- Add 'Sia' to Cosmos tests note - Add --profile all to compose down command

These tests hit external price APIs which may fail in CI due to network restrictions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Use the same commit hash (635112d5) for fetch-params-alt.sh across all workflows and docs. This version includes macOS fixes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

…keys) The newer commit (635112d5) no longer downloads sprout keys, which the testblockchain image requires. Reverting to v0.8.1 until #2231 is resolved. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

The test was flaky on slow CI (Windows) because each of the 10 remove_order() calls did a synchronous flush, taking >3s total. This exceeded TRIE_ORDER_HISTORY_TIMEOUT causing history entries to expire and from_history() to return FullTrie instead of Delta. Fix: batch all removals into one operation with a single flush. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

mm2src/mm2_main/src/ordermatch_tests.rs

mariocynicys

thanks!
LGTM

shamardy and others added 30 commits December 4, 2025 15:37

debug(sia): add logging to diagnose CI test failure

4840604

Adds logging to wait_for_dsia_node_ready() to track: - When mining starts - Current height after mining completes This will help diagnose why test_sia_client_address_balance fails in CI but passes locally.

feat(docker-tests): add roadmap and plan for docker tests refactor an…

d8e94cb

…d CI split

shamardy and others added 3 commits December 16, 2025 19:18

Merge branch 'dev' into tests/split-docker-tests

825e8d3

Brings endpoint migration from #2704 (moralis/antispam/prices endpoints moved to gleec.com)

shamardy mentioned this pull request Dec 16, 2025

fix(orderbook): reduce invalid states and improve sync reliability #2626

Draft

shamardy and others added 2 commits December 16, 2025 21:07

shamardy force-pushed the tests/split-docker-tests branch from 68e2d89 to 3111a82 Compare December 16, 2025 22:47

github-actions bot added the [] label Dec 18, 2025

shamardy removed the [] label Dec 18, 2025

mariocynicys reviewed Dec 18, 2025

View reviewed changes

mariocynicys reviewed Dec 19, 2025

View reviewed changes

.docker/test-nodes.yml Show resolved Hide resolved

.github/workflows/test.yml Show resolved Hide resolved

github-actions bot added the [] label Dec 23, 2025

shamardy force-pushed the tests/split-docker-tests branch from 4449b9c to dda7c87 Compare January 2, 2026 06:49

shamardy and others added 4 commits January 2, 2026 09:07

refactor(docker-tests): remove unnecessary fallback in resolve_compos…

c63f886

…e_container_id Docker-compose always adds the com.docker.compose.service label, so the container name fallback would never trigger.

fix(tests): use approximate comparison in test_update_maker_order

4b90282

Fee/balance can change slightly between the my_balance/trade_preimage calls and the update_maker_order call, causing flaky test failures.

fix(ci): add --skip-sia to Tendermint docker tests

2a4db4c

Tendermint tests only need Cosmos node setup, not Sia config.

shamardy mentioned this pull request Jan 2, 2026

Improve macOS local development support for docker tests #2709

Open

shamardy and others added 4 commits January 2, 2026 09:48

docs(docker-tests): update setup instructions

5282d49

- Add 'Sia' to Cosmos tests note - Add --profile all to compose down command

test(coins): ignore lp_price tests requiring external API

3bf085e

These tests hit external price APIs which may fail in CI due to network restrictions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shamardy requested a review from mariocynicys January 2, 2026 09:05

mariocynicys reviewed Jan 2, 2026

View reviewed changes

mm2src/mm2_main/src/ordermatch_tests.rs Show resolved Hide resolved

mariocynicys approved these changes Jan 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(ci): split docker tests into feature-gated parallel suites #2707

refactor(ci): split docker tests into feature-gated parallel suites #2707

Uh oh!

shamardy commented Dec 16, 2025 •

edited

Loading

Uh oh!

mariocynicys left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Uh oh!

Uh oh!

Uh oh!

shamardy commented Dec 31, 2025

Uh oh!

Uh oh!

mariocynicys left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(ci): split docker tests into feature-gated parallel suites #2707

Are you sure you want to change the base?

refactor(ci): split docker tests into feature-gated parallel suites #2707

Uh oh!

Conversation

shamardy commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Features Added

Key Changes

Related Issues

Flaky Tests Ignored

Test Plan

Review Plan

Quick scan (file moves, no logic changes)

Focus areas for detailed review

What NOT to focus on

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shamardy commented Dec 31, 2025

Uh oh!

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shamardy commented Dec 16, 2025 •

edited

Loading