Add Content-Security-Policy meta tag #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to GSA/data.gov#4952
About
This adds a Content-Security-Policy as a meta tag in our base template.
One of the NPM packages we use
glossary-panelhas in it's latest released version a use of underscore'stemplatefunction which callsFunctionwhich is not allowed without theunsafe-evaldirective. Unfortunately, there is actually code in themasterbranch of https://github.com/18F/glossary to avoid that issue, but it hasn't been released to NPM. Rather than attempt to get a release made for that library, after reviewing the code, we accept thatFunctionis being used safely and include theunsafe-evaldirective.PR TASKS