Skip to content

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 17, 2025

This is working towards a new queries-over-time component, by refactoring the mutations-over-time-grid into a reusable component.

Summary

Rename MutationsOverTimeGrid to FeaturesOverTimeGrid and make it generic. You now need to also supply a:

FeatureRenderer<D> {
    asString(value: D): string;
    renderRowLabel(value: D): JSX.Element;
    renderTooltip(value: D, temporal: Temporal, proportionValue: ProportionValue | undefined): JSX.Element;
}

Rename MutationOverTimeMutationValue to ProportionValue as it's not mutation specific.

Screenshot

n/a

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
dashboard-components Error Error Jan 15, 2026 9:22am

@github-actions
Copy link
Contributor

There is no change in the changelog. This PR will not produce a new releasable version.

@fhennig fhennig changed the title WIP refactor(components): refactor mutations-over-time-grid into generic features-over-time-grid Dec 18, 2025
@fhennig fhennig self-assigned this Dec 18, 2025
@fhennig fhennig marked this pull request as ready for review December 18, 2025 10:27
Copy link
Collaborator

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig
Copy link
Contributor Author

fhennig commented Jan 7, 2026

re-running test - there were 3 failures.

@fhennig
Copy link
Contributor Author

fhennig commented Jan 7, 2026

hmm weird, another test failure, definitely some flakiness going on, I'll need to investigate

@fhennig fhennig force-pushed the refactor-over-time branch from 7bdb080 to 6dfec5f Compare January 15, 2026 09:22
@fhennig fhennig merged commit 12110b7 into main Jan 15, 2026
6 of 9 checks passed
@fhennig fhennig deleted the refactor-over-time branch January 15, 2026 09:41
@fhennig
Copy link
Contributor Author

fhennig commented Jan 15, 2026

The tests were just flaky, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants