-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(components): refactor mutations-over-time-grid into generic features-over-time-grid #1058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There is no change in the changelog. This PR will not produce a new releasable version. |
77c1544 to
c66d8f8
Compare
fengelniederhammer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
re-running test - there were 3 failures. |
|
hmm weird, another test failure, definitely some flakiness going on, I'll need to investigate |
6257ef1 to
7bdb080
Compare
7bdb080 to
6dfec5f
Compare
|
The tests were just flaky, unfortunately. |
This is working towards a new
queries-over-timecomponent, by refactoring themutations-over-time-gridinto a reusable component.Summary
Rename
MutationsOverTimeGridtoFeaturesOverTimeGridand make it generic. You now need to also supply a:Rename
MutationOverTimeMutationValuetoProportionValueas it's not mutation specific.Screenshot
n/a
PR Checklist
All necessary documentation has been adapted.The implemented feature is covered by an appropriate test.