-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement get_caf
#32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit b243519.
get_caf
jsstevenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple small tweaks at the level of the client interface
jennifer-bowser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor potential suggestions/questions!
jennifer-bowser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a test now that's failing on this PR that isn't failing for me on main:
FAILED tests/unit/anyvar/test_clients.py::test_get_registered_allele_expressions_unpopulated[anyvar_http_client] - AssertionError: assert Allele(id='ga4gh:VA.Otc5ovrw906Ack087o1fhegB4jDRqCAe', type='Allele', name=None, description=None, aliases=None, exten...ralSequenceExpression', name=None, description=None...
@jennifer-bowser Can you try wiping your AnyVar DB? All tests are passing in CI 🤔 In anyvar: from dotenv import load_dotenv
load_dotenv()
from os import environ
uri = environ["ANYVAR_STORAGE_URI"]
from anyvar.anyvar import create_storage
s = create_storage(uri)
s.wipe_db() |
The test is still failing for me, but if it's passing for others/CI then I don't want to hold things up. I'll approve this! |
jennifer-bowser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests are now passing for me
close #16
AnyVlmCohortAlleleFrequencyResultwhich extendsCohortAlleleFrequencyStudyResult(replaces dictionary fields with Pydantic fields)get_caf, we'll want to make the distinction between no CAF results due to variant not being registered in AnyVar vs no CAF data foundYou'll want to update your deps