Skip to content

Conversation

@korikuzma
Copy link
Member

@korikuzma korikuzma commented Dec 12, 2025

close #16

  • Creates AnyVlmCohortAlleleFrequencyResult which extends CohortAlleleFrequencyStudyResult (replaces dictionary fields with Pydantic fields)
  • Made the assumption that in get_caf, we'll want to make the distinction between no CAF results due to variant not being registered in AnyVar vs no CAF data found

You'll want to update your deps

@korikuzma korikuzma self-assigned this Dec 12, 2025
@korikuzma korikuzma requested a review from a team as a code owner December 12, 2025 19:52
@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Dec 12, 2025
@korikuzma korikuzma linked an issue Dec 12, 2025 that may be closed by this pull request
2 tasks
@korikuzma korikuzma marked this pull request as draft December 17, 2025 15:20
@korikuzma korikuzma changed the title feat: add anyvlm client for caf retrieval feat: implement get_caf Dec 17, 2025
@korikuzma korikuzma marked this pull request as ready for review December 23, 2025 14:45
@korikuzma korikuzma requested a review from a team December 23, 2025 14:45
Copy link
Member

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small tweaks at the level of the client interface

jsstevenson
jsstevenson previously approved these changes Dec 23, 2025
Base automatically changed from issue-23 to main December 24, 2025 21:35
@korikuzma korikuzma dismissed jsstevenson’s stale review December 24, 2025 21:35

The base branch was changed.

Copy link
Contributor

@jennifer-bowser jennifer-bowser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor potential suggestions/questions!

@jennifer-bowser jennifer-bowser self-requested a review December 29, 2025 15:55
Copy link
Contributor

@jennifer-bowser jennifer-bowser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a test now that's failing on this PR that isn't failing for me on main:

FAILED tests/unit/anyvar/test_clients.py::test_get_registered_allele_expressions_unpopulated[anyvar_http_client] - AssertionError: assert Allele(id='ga4gh:VA.Otc5ovrw906Ack087o1fhegB4jDRqCAe', type='Allele', name=None, description=None, aliases=None, exten...ralSequenceExpression', name=None, description=None...

@korikuzma
Copy link
Member Author

korikuzma commented Dec 29, 2025

I'm getting a test now that's failing on this PR that isn't failing for me on main:

FAILED tests/unit/anyvar/test_clients.py::test_get_registered_allele_expressions_unpopulated[anyvar_http_client] - AssertionError: assert Allele(id='ga4gh:VA.Otc5ovrw906Ack087o1fhegB4jDRqCAe', type='Allele', name=None, description=None, aliases=None, exten...ralSequenceExpression', name=None, description=None...

@jennifer-bowser Can you try wiping your AnyVar DB? All tests are passing in CI 🤔

In anyvar:

from dotenv import load_dotenv
load_dotenv()

from os import environ
uri = environ["ANYVAR_STORAGE_URI"]
from anyvar.anyvar import create_storage
s = create_storage(uri)
s.wipe_db()

@jennifer-bowser
Copy link
Contributor

jennifer-bowser commented Dec 29, 2025

@jennifer-bowser Can you try wiping your AnyVar DB? All tests are passing in CI 🤔

In anyvar:

from os import environ
uri = environ["ANYVAR_STORAGE_URI"]
from anyvar.anyvar import create_storage
s = create_storage(uri)
s.wipe_db()

The test is still failing for me, but if it's passing for others/CI then I don't want to hold things up. I'll approve this!

Copy link
Contributor

@jennifer-bowser jennifer-bowser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are now passing for me

@korikuzma korikuzma merged commit 0ae941d into main Dec 29, 2025
14 checks passed
@korikuzma korikuzma deleted the issue-16 branch December 29, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority:medium Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write function to retrieve CAF data for VLM response

4 participants