44 formatter portal check rebased #110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etadataUuid}/formatters/{formatterId:.+} (geonetwork#8269)
This affect PDF exports on working copies.
…network#7969 (geonetwork#8262) Use the UI language for the metadata information, when exporting a metadata selection to CSV / PDF. The API for these services accept a new optional parameter language that defaults to English as previously. Fixes geonetwork#7969.
* Zoom to map popup remains active on non-map pages. Fixes geonetwork#8260 Fixes also wrong values for add alert delay, provided in some pages in milliseconds, but the method expects seconds. * Zoom to map popup remains active on non-map pages - remove alerts only when switching from the map * Increase timeout to hide layer added popup to 15 seconds
In the register user, metadata feedback and user feedback forms, sometimes the settings with the recaptcha keys takes a bit longer to load making the recaptcha widget not to load. This commit fixes that updating the values of the recaptcha settings when the settings have finished loading. It also resets the recaptcha widget if there is any problem returned by the server after sending the form.
…sfer options block are used. (geonetwork#8281) * Standard / ISO19139 / Fix removal of online source when multiple transfer options block are used. Follow up of geonetwork#7431 * Fix online resource update/delete so that it supports multiple gmd:MD_DigitalTransferOptions blocks. --------- Co-authored-by: Ian Allen <ianwallen@hotmail.com>
* Update batch PDF export to skip working copies * Capitalize boolean operators in lucene query
Before only maintenance frequency was displayed but more information may be provided about the maintenance (eg. custom frequency, next update date, note).
) On application startup, the translation pack may report an error like the following ``` org.fao.geonet.api.exception.ResourceNotFoundException at org.fao.geonet.api.standards.StandardsUtils.getCodelistOrLabel(StandardsUtils.java:72) at org.fao.geonet.api.standards.StandardsUtils.getLabel(StandardsUtils.java:55) at org.fao.geonet.api.tools.i18n.TranslationPackBuilder.getStandardLabel(TranslationPackBuilder.java:217) ``` due to a missing french translation for element `DQ_EvaluationMethodTypeCode` Follow up of geonetwork#7180
…work#8303) - other harvester have same or higher loglevel as well - helps to identify invalid metadata
…onetwork#8317) * Repository Citation.cff metadata for DUI regestration with zenodo * Update CITATION.cff Minor updates, additions and clean up * Update CITATION.cff Simplified the list to only include active PSC members --------- Co-authored-by: Jeroen Ticheler <Jeroen.Ticheler@GeoCat.net>
Clipboard permissions are only implemented in Chromium-based browsers. See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard for more details Instead, check if the browser supports the writeText/readText clipboard functions (some mobile browsers and older firefox versions do not). With these change, both Chromium-based browsers and other browsers such as firefox work correctly
…lling a submission (geonetwork#8264) * Workflow / update notification level based on user profile when cancelling a submission: - cancel working copy (from editor) --> should be notified the reviewer. - rejection (from reviewer) --> should be notified the editor. * Update core/src/main/java/org/fao/geonet/kernel/metadata/DefaultStatusActions.java Co-authored-by: Ian <ianwallen@hotmail.com> * Fix code suggestion missing bracket --------- Co-authored-by: Ian <ianwallen@hotmail.com>
Fixes geonetwork#8255 Co-authored-by: ByronCinNZ <cochranes4@eml.cc>
In case of XSL error, index document was containing an array instead of single value
```
"draft": [
"n",
"n"
],
```
Draft field is added by the database info so no need to add it again on XSL error. Properly set it in case of indexing error.
not causing issue in current app (but will be more strict in index document model).
Follow up of geonetwork#8320, that causes issues in 4.2.x. Added the change to main branch to avoid issues in future backports of changes in this file.
…r overview (geonetwork#8225) Overview file name is stored in `mcc:fileName`
* Admin / Source / Improve dirty state Due to wrong `form` tag placement, dirty state was only set when changing portal id and filter - not UI config, service or logo. Reorganize the form to improve this, so that save action is enabled when changing the form. Also keep the logo form upload not nested (because it would not work) * Update SourcesController.js * Admin / Source / Hide logo if not available.
When adding a source for example, the button label may be empty. Add a default one.
…rtain conditions (geonetwork#8069) * CSW Harvester / Avoid increment 2 metrics for a single metadata in certain conditions. Retrieve metadata method increments metrics under certain conditions and returns null. Methods calling the retrieve metadata method increments additionally the unretrievable metric if null is returned. Sonarlint fixeas are already applied. Fixes geonetwork#8039 * CSW Harvester / Use primitive boolean for 'force' parameter
ISO metadata can be retrieved in DCAT and specific rules apply to High Value Dataset context. See https://semiceu.github.io/DCAT-AP/releases/2.2.0-hvd/ This schematron test ISO19139 or ISO19115-3 records and check mandatory elements for datasets and services. The mapping rule defined in the ISO to DCAT mapping are used (and some rules may require adaptation depending on user rules eg. no common practice to encode service documentation which is mandatory for HVD). Relates to geonetwork#8547
* support section variable in manual url * isoLang variable, help wording * Revert "isoLang variable, help wording" This reverts commit 0b000ce * ignore path "/" for default language replacement * Update web-ui/src/main/resources/catalog/locales/en-admin.json Co-authored-by: Jose García <josegar74@gmail.com> * remove double slash * remove double slash in error handler --------- Co-authored-by: Jose García <josegar74@gmail.com>
Preview on intellij or github is not the same as mkdoc pages. List requires blank line above.
* Formatters / Properly detect URL ending in 1,2,3 or 5 Fixes geonetwork#8226 * Update utility-tpl.xsl
…#8041) A feature catalogue can contain one or more feature types description. When describing a model with lots of feature types, then the editor can be quite large (and then can cause issue related to timeout or number of fields) The problem is quite similar to geonetwork#7998 (ie. timeout, number of form fields). To better manage this case, make a list of existing feature types and user can click on it to edit only one feature type at a time. This is enable by default for ISO19110 and ISO19115-3 feature catalogue in all views. The first table is selected by default. A selector can be manually configured using the following: ```xml <section name="gfc:featureType"> <select name="Select a feature type" xpath="/gfc:FC_FeatureCatalogue/gfc:featureType" parameter="featureType" value="*/gfc:typeName/gco:LocalName/text()" layout="dropdown"/> <!--tabs|pills|dropdown--> <section xpath="/gfc:FC_FeatureCatalogue/gfc:featureType[ */gfc:typeName/gco:LocalName = $p2/featureType or (not($p2/featureType) and position() = 1) or ($p3 = 'md.format.html')]" or="featureType" in="/gfc:FC_FeatureCatalogue"/> </section> ``` `$p2` correspond to the variable `request` and `$p3` to the `service` in the XSL template (see `base-variables.xsl` and `evaluate.xsl`). So if there is no `featureType` parameter, the first feature type will be displayed. If the view mode is `md.format.html`, all feature types will be displayed. It has only been tested for feature catalogue but can be probably reuse in other places eg. conformity * Dropdown (default) * Tabs * Pills * Avoid JS error on large forms by using JQuery `empty()` instead of find and remove: ``` RangeError: Maximum call stack size exceeded at Sizzle.select (jquery-2.2.4.js?v=dc93b22fa65aadfbbe3d7ad69b4d5d83601574de:2592:12) at Function.Sizzle [as find] (jquery-2.2.4.js?v=dc93b22fa65aadfbbe3d7ad69b4d5d83601574de:869:9) at jQuery.fn.init.find (jquery-2.2.4.js?v=dc93b22fa65aadfbbe3d7ad69b4d5d83601574de:2792:11) at refreshForm (EditorService.js:324:42) ``` * ISO19110 to ISO19115-3 conversion / Convert cardinality to CharacterString
* Editor / Add unit as main field Couple of ISO elements have a `uom` attribute to define unit of measure, length, distance or angle. Attributes are usually displayed only if enabled (using the "more details" menu). Add a specific mechanism to be able to display an attribute next to the main field it relates to. Also add in the field label the type of field because resolution can be of various types (measure, length, ...). Funded by Ifremer * Editor / Add unit attribute completion from thesaurus. * Editor / Add unit attribute completion from thesaurus / ISO19139 alignement and thesaurus. --------- Co-authored-by: Jose García <josegar74@gmail.com>
When scale factor is big, image generated always follows geom proportions. It may not be relevant as the geom is small on the image and a square image may be preferred.
* Facet / Add meta property to customize label. Add also documentation on how to configure labels when the key used for the facet is not known. * Facet / Add meta property to customize label. * Facet / Add meta property to customize label. Apply translation key filter in getFacetLabel --------- Co-authored-by: Jose García <josegar74@gmail.com>
Security configuration for GeoNetwork 4 deployed behing GeoNetwork 5 prototype using simple mode (ie. GN4 MUST not be exposed to intranet and internet). Authentication is managed by version 5 which check user credentials and create user in the database if needed. Then a JWT token is added to a header that version 4 checks. Related to: * JWT headers support geonetwork#7899 * GeoNetwork 5 auth geonetwork/geonetwork#77 To enable the configuration, use: ```sh mvn jetty:run -Dgeonetwork.security.type=gn5 ```
…x filenames containing spaces. (geonetwork#8581)
…work#8582) Prior to this fix, the swagger ui for applying site settings was not working.
Identified the media type that is being stored in the database. Instead of detecting if data is json or xml, instead base it on the media type for the event.
…ge source descriptions (geonetwork#8595) angular.js?v=2e31720b368df88f570059d390b081d82fe9cf75:15697 Error: [linky:notstring] Expected string but received: [...
Update the "Creating group" section to match 4.2 user interface
…at are valid. (geonetwork#8598) If the dates are not valid causes an error in the index, failing the search when the metadata is returned
* Check content-length of resource at url * Remove unnecessary throw * Fallback to InputStream.available() if content length is not found or smaller * Fallback maxUploadSize for unit tests * Fix default value always used * Remove content-length check as it cannot be trusted * Download file to a temp file to check size * Add back the content-length check as a preliminary check * Stream file instead of using temp file * Rollback for JCloud * Fix rollback for JCloud * Fix abstract store and implement jcloud rollback * Fix typo and remove unused import * Fix unit tests * Fix tests (mock response code) * Fix unit test, refactor, and add docs * Fix exception handling and use bounded input stream instead of custom input stream * Improvements * Add documentation * Rename exception * Remove unneeded changes * Update docs * Fix comment Co-authored-by: Ian <ianwallen@hotmail.com> * Update exception handling * Update jcloud exception handling and comments * Add file header * Add comment * Fix whitespace --------- Co-authored-by: Ian <ianwallen@hotmail.com>
* Audit user changes * Audit user changes - update translations * Add README.md file * Update UserAuditable model to track user address changes and add unit test for UserAuditable * Audit user changes - change to use Hibernate Envers due to Javers dependency conflict with Geotools for the picocontainer version * Audit user changes - update README.md documentation * Code formatting and styling * Update UsersApi to remove invalid user group assignment in the user update endpoint --------- Co-authored-by: Juan Luis Rodríguez <juanluisrp@gmail.com>
Co-authored-by: david.blasby <david.blasby@geocat.net>
…port getting working copy records history. (geonetwork#8153) * Update getRecordStatusHistory and getRecordStatusHistoryByType to support getting working copy records history. * Also include workflow/last api in the changes. * Update can edit to use non approved records when not specified.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation