Skip to content

Conversation

@Thomas-Benson
Copy link
Contributor

@Thomas-Benson Thomas-Benson commented Aug 19, 2025

WHSB building array has been upgraded to EQR120 recorders
All recorders now have orientation 257, and axial stream codes

@Thomas-Benson Thomas-Benson self-assigned this Aug 19, 2025
@Thomas-Benson Thomas-Benson marked this pull request as ready for review August 20, 2025 23:25
@Thomas-Benson Thomas-Benson requested review from a team and ozym as code owners August 20, 2025 23:25
Copy link
Contributor

@salichon salichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thomas-Benson

  • numerous recorders with a negative "depth" (okay height in the building)

but

  • the sites are all at 16.4 meters elevation
    WHSB,21,-41.308301,174.779271,16.4,,NZGD2000,External GPS Device,2009-04-15T00:00:03Z,9999-01-01T00:00:00Z

    and
  • the station is also 16.4 meters high

Perhaps shall we clarify/disasambiguate ?
e.g
sites at 0 ?
or sites with the elevation and recorders at 0 ?
(or any specs to building arrays / rules)

minor but bring that question for clarity and users :)
thanks !

@salichon
Copy link
Contributor

yo @Thomas-Benson - shall we finlaize Welli hospital that building one ?
cheers

@Thomas-Benson
Copy link
Contributor Author

I think this is consistent with what we do with other building arrays?
16.4m elevation for the station/site entries is the ground level of the building, and the depths account for the position within the building.
Putting the site elevations at zero wouldn't work unless the elevation was added to the depths, which would be less obvious for users.
the only reasonable way to simplify it would be to remove the depths and adjsut the elevations, but this would be going against the conventions used for the other building arrays

@salichon
Copy link
Contributor

Ok thanks :)

@salichon salichon self-requested a review September 22, 2025 03:25
salichon
salichon previously approved these changes Sep 22, 2025
Copy link
Contributor

@salichon salichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta
pikpok @CBurton90 :))

CBurton90
CBurton90 previously approved these changes Sep 22, 2025
@salichon
Copy link
Contributor

..or maybe fell inot a crack!

@Thomas-Benson Thomas-Benson force-pushed the WHSB-EQR120-upgrade branch 2 times, most recently from 157f8b4 to ed59a48 Compare December 19, 2025 01:46
@Thomas-Benson
Copy link
Contributor Author

Had a very painful clash with the mass EQR120 firmware updates in #2637

Copy link
Contributor

@salichon salichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pfiuuu
thanks!
See later for merging aye!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants