Skip to content

Conversation

@salichon
Copy link
Contributor

@salichon salichon commented Sep 23, 2025

DART deployments Updates - and latest NIWA data ingestion

@salichon salichon self-assigned this Sep 23, 2025
@salichon salichon requested review from a team and ozym as code owners September 23, 2025 05:02
@salichon
Copy link
Contributor Author

salichon commented Sep 23, 2025

Start and end times based upon FDSN main output for DART systems

@salichon
Copy link
Contributor Author

Added the full niwa data set for NZA 40/41/42
to be validated

@salichon salichon changed the title DART Tidal constituents in Delta - Step 1 DART NIWA Tidal constituents in Delta - Step 1: Fix Loccode and Time windows; ADD NZA constituents example) Sep 24, 2025
@salichon salichon changed the title DART NIWA Tidal constituents in Delta - Step 1: Fix Loccode and Time windows; ADD NZA constituents example) DART NIWA Tidal constituents in Delta - Step 1: Fix Loccode and Time windows; ADD DART NZ constituents example) Sep 25, 2025
@salichon salichon changed the title DART NIWA Tidal constituents in Delta - Step 1: Fix Loccode and Time windows; ADD DART NZ constituents example) DART NIWA Tidal constituents in Delta - Step 1: FIX Loccode and Time windows; Step 2 ADD DART NZ constituents Sep 25, 2025
@salichon
Copy link
Contributor Author

salichon commented Sep 25, 2025

@salichon
Copy link
Contributor Author

This PR si still pending
It d be greta to get it reviewed @JonoHanson @EvanCGNS et al.
thanks !

@salichon
Copy link
Contributor Author

@EvanCGNS after the tilde PR would you have a look on this PR - thanks

@JonoHanson
Copy link
Contributor

nice, looks good to me - however I wouldn't a quick numbers double check from @EvanCGNS before merging.

thanks @salichon for pushing this along!

Copy link
Contributor

@EvanCGNS EvanCGNS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timestamps have the correct UTC days, and the hours/minutes/seconds are mostly correct but a little inconsistent. I don't think it will affect de-tiding (much) so you're probably fine to merge 😄

The constituents themselves look good to me!

@EvanCGNS EvanCGNS self-requested a review December 9, 2025 00:55
@salichon
Copy link
Contributor Author

salichon commented Dec 9, 2025

  • Check downstream impacts of the chnages Tilde/lasso/ac-tool -before merging

@salichon
Copy link
Contributor Author

salichon commented Jan 11, 2026

@EvanCGNS - I Will merge this PR - Please check with ~tilde a wee later that this PR doesn t mess up with the detiding of the DART
thanks !

@salichon salichon merged commit 689c7f7 into main Jan 11, 2026
18 checks passed
@salichon salichon deleted the DART_ConstitUpdate branch January 11, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants