Skip to content

fix(Topology): add try/catch to avoid exception failings #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 3 commits into from
Jan 12, 2026
Merged

fix(Topology): add try/catch to avoid exception failings #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21e9a6c
fix(Topology): add try/catch to avoid exception failings
panquez Jan 6, 2026
dc232ae
Pr review
panquez Jan 9, 2026
8d68020
fix compilation
panquez Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions src/geode/inspector/topology/brep_topology.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,22 +176,29 @@ namespace geode
const BRepTopologyInspector& brep_topology_inspector ) const
{
BRepTopologyInspectionResult result;
async::parallel_invoke(
[&result, &brep_topology_inspector] {
result.corners =
brep_topology_inspector.inspect_corners_topology();
},
[&result, &brep_topology_inspector] {
result.lines =
brep_topology_inspector.inspect_lines_topology();
},
[&result, &brep_topology_inspector] {
result.surfaces =
brep_topology_inspector.inspect_surfaces_topology();
},
[&result, &brep_topology_inspector] {
result.blocks = brep_topology_inspector.inspect_blocks();
} );
try
{
async::parallel_invoke(
[&result, &brep_topology_inspector] {
result.corners =
brep_topology_inspector.inspect_corners_topology();
},
[&result, &brep_topology_inspector] {
result.lines =
brep_topology_inspector.inspect_lines_topology();
},
[&result, &brep_topology_inspector] {
result.surfaces =
brep_topology_inspector.inspect_surfaces_topology();
},
[&result, &brep_topology_inspector] {
result.blocks =
brep_topology_inspector.inspect_blocks();
} );
}
catch( OpenGeodeException& )
{
}
add_unique_vertices_with_wrong_cmv_link( result );
return result;
}
Expand Down
25 changes: 21 additions & 4 deletions src/geode/inspector/topology/section_topology.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#include <geode/inspector/topology/section_topology.hpp>

#include <async++.h>

#include <geode/basic/logger.hpp>
#include <geode/basic/pimpl_impl.hpp>

Expand Down Expand Up @@ -170,10 +172,25 @@ namespace geode
const SectionTopologyInspector& section_topology_inspector ) const
{
SectionTopologyInspectionResult result;
result.corners =
section_topology_inspector.inspect_corners_topology();
result.lines = section_topology_inspector.inspect_lines_topology();
result.surfaces = section_topology_inspector.inspect_surfaces();
try
{
async::parallel_invoke(
[&result, &section_topology_inspector] {
result.corners = section_topology_inspector
.inspect_corners_topology();
},
[&result, &section_topology_inspector] {
result.lines =
section_topology_inspector.inspect_lines_topology();
},
[&result, &section_topology_inspector] {
result.surfaces =
section_topology_inspector.inspect_surfaces();
} );
}
catch( OpenGeodeException& )
{
}
add_unique_vertices_with_wrong_cmv_link( result );
return result;
}
Expand Down