Skip to content

Conversation

@MaxNumerique
Copy link
Contributor

No description provided.

<ViewerSpecificEdgesOptions
:itemProps="props.itemProps"
:btn_image="EdgedCurveEdges"
:index="props.index"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le index il sert à quoi ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est de la PR de Tao pour ne pas que les éléments du contexte nu ne se chevauchent de ce que j'ai compris

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C’est de la PR de Tao pour ne pas que les éléments du contexte nu ne se chevauchent de ce que j'ai compris

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A supprimer du coup non ?

:itemProps="itemProps"
tooltip="Edges options"
:btn_image="SurfaceEdges"
:index="props.index"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y a t-il une prop index ?

:itemProps="props.itemProps"
tooltip="Points options"
:btn_image="SurfacePoints"
:index="props.index"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pareil ici

import back_schemas from "@geode/opengeodeweb-back/opengeodeweb_back_schemas.json"
import { useGeodeStore } from "@ogw_front/stores/geode"
const geodeStore = useGeodeStore()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est toujours génial de découvrir ce genre de choses...

return setMeshPointsColor(id, coloring.color)
} else if (type == "vertex" && coloring.vertex !== null) {
} else if (type === "vertex") {
if (coloring.vertex === null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BotellaA C'est quoi le mieux dans cette situation ? Un early return ou le moins d'indentations possible ?


// Local constants
const mesh_polygons_schemas = viewer_schemas.opengeodeweb_viewer.mesh.polygons
const mesh_points_schemas = viewer_schemas.opengeodeweb_viewer.mesh.points
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suppr

describe("Polyhedra color", () => {
test("Color red", async () => {

describe("Polygons", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas le scope de ce fichier, pareil pour tout ce qui est en dessous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants