-
Notifications
You must be signed in to change notification settings - Fork 2
Fix/context menu edged curve #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…b-Front into fix/context_menu_edged_curve
… and fix EdgedCurve technical issues
…de-solutions/OpenGeodeWeb-Front into fix/context_menu_edged_curve
…b-Front into fix/context_menu_edged_curve
…b-Front into fix/context_menu_edged_curve
…de-solutions/OpenGeodeWeb-Front into fix/context_menu_edged_curve
| <ViewerSpecificEdgesOptions | ||
| :itemProps="props.itemProps" | ||
| :btn_image="EdgedCurveEdges" | ||
| :index="props.index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le index il sert à quoi ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C’est de la PR de Tao pour ne pas que les éléments du contexte nu ne se chevauchent de ce que j'ai compris
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C’est de la PR de Tao pour ne pas que les éléments du contexte nu ne se chevauchent de ce que j'ai compris
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A supprimer du coup non ?
| :itemProps="itemProps" | ||
| tooltip="Edges options" | ||
| :btn_image="SurfaceEdges" | ||
| :index="props.index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Y a t-il une prop index ?
| :itemProps="props.itemProps" | ||
| tooltip="Points options" | ||
| :btn_image="SurfacePoints" | ||
| :index="props.index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pareil ici
| import back_schemas from "@geode/opengeodeweb-back/opengeodeweb_back_schemas.json" | ||
| import { useGeodeStore } from "@ogw_front/stores/geode" | ||
| const geodeStore = useGeodeStore() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est toujours génial de découvrir ce genre de choses...
| return setMeshPointsColor(id, coloring.color) | ||
| } else if (type == "vertex" && coloring.vertex !== null) { | ||
| } else if (type === "vertex") { | ||
| if (coloring.vertex === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BotellaA C'est quoi le mieux dans cette situation ? Un early return ou le moins d'indentations possible ?
|
|
||
| // Local constants | ||
| const mesh_polygons_schemas = viewer_schemas.opengeodeweb_viewer.mesh.polygons | ||
| const mesh_points_schemas = viewer_schemas.opengeodeweb_viewer.mesh.points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suppr
| describe("Polyhedra color", () => { | ||
| test("Color red", async () => { | ||
|
|
||
| describe("Polygons", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas le scope de ce fichier, pareil pour tout ce qui est en dessous
No description provided.