Skip to content

feat(LWW): max_size, avoid 0 sizes #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeopJr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(LWW): max_size, avoid 0 sizes #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Widgets/EmojiLabel.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class Tuba.Widgets.EmojiLabel : Tuba.Widgets.LabelWithWidgets {
}

public EmojiLabel (string? text = null, Gee.HashMap<string, string>? emojis = null) {
Object ();
Object (max_size: 128);
if (text == null) return;

instance_emojis = emojis;
Expand Down
18 changes: 18 additions & 0 deletions src/Widgets/LabelWithWidgets.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ public class Tuba.Widgets.LabelWithWidgets : Gtk.Widget, Gtk.Buildable, Gtk.Acce
}
}

private int _max_size = -1;
public int max_size {
get {
return _max_size;
}
set {
if (_max_size == value) return;

_max_size = value;
invalidate_child_widgets ();
}
}

const string OBJECT_REPLACEMENT_CHARACTER = "\xEF\xBF\xBC";

construct {
Expand Down Expand Up @@ -93,6 +106,11 @@ public class Tuba.Widgets.LabelWithWidgets : Gtk.Widget, Gtk.Buildable, Gtk.Acce
widgets[i].widget.get_preferred_size (out size, out natural_size);
int width = natural_size.width;
int height = natural_size.height;
if (width == 0 || height == 0) return;
if (max_size > 0) {
width = int.min (width, max_size);
height = int.min (height, max_size);
}

int old_width = widgets[i].width;
int old_height = widgets[i].height;
Expand Down