fix(components-native): Fix Form's bottom inset SafeArea for inline type FormActionBar #2813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakitine
commented
Nov 12, 2025
| }: FormBodyProps): JSX.Element { | ||
| const paddingBottom = useBottomPadding(); | ||
| const fullViewPadding = useMemo(() => ({ paddingBottom }), [paddingBottom]); | ||
| const { bottom: paddingBottom } = useSafeAreaInsets(); |
Contributor
Author
There was a problem hiding this comment.
useBottomPadding was doing some extra minuses for padding.. I needed the unaltered value from SafeAreaInsets.
krakitine
commented
Nov 12, 2025
| </View> | ||
|
|
||
| {shouldRenderActionBar && !saveButtonOffset && ( | ||
| {!saveButtonOffset && ( |
Contributor
Author
There was a problem hiding this comment.
This is the crux of the fix, where I show this extra "safeArea" view at all times
for iOS and Android <15, this view is zero height
krakitine
commented
Nov 12, 2025
| ref={scrollViewRef} | ||
| {...keyboardProps} | ||
| extraHeight={headerHeight} | ||
| extraScrollHeight={edgeToEdgeEnabled ? tokens["space-large"] : 0} |
Contributor
Author
There was a problem hiding this comment.
@omairJobber this did not seem necessary with this fix
|
Published Pre-release for 547612b with versions: To install the new version(s) for Mobile run: |
omairJobber
approved these changes
Nov 14, 2025
Contributor
Author
|
Blocking this guy for when we resume this a little later. Keeping PR around as we might still use this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Form's FormActionBar (save button) on Android devices with edge-to-edge enabled was showing Form content over the navigation. This PR adds a fix to add proper insets for "inline" style FormActionBar
Before
After
Changes
Fixed
Testing
I tested using three Android emulators.
One with Android 14, two with Android 16 (one using gesture navigation, the other button navigation)
Use an android build with edge-to-edge enabled.
Load up a form long enough that it has a scroll.
Notice that on the Android that supports edge-to-edge (15+), the form content is not visible over the bottom system navigation bar
Changes can be
tested via Pre-release