Example Only Do Not Merge: Data Attributes

[ZakaryH]

Motivations

Changes

Added

Changed

Deprecated

Removed

Fixed

Security

Testing

Changes can be
tested via Pre-release

---

In Atlantis we use Github's built in pull request reviews.

[github-actions]

⚠️ Pull Request titles in this repo follow the Conventional Commits specification.

No release type found in pull request title "Example Only Do Not Merge: Data Attributes". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

• feat: A new feature
• fix: A bug fix
• docs: Documentation only changes
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• refactor: A code change that neither fixes a bug nor adds a feature
• perf: A code change that improves performance
• test: Adding missing tests or correcting existing tests
• build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
• ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
• chore: Other changes that don't modify src or test files
• revert: Reverts a previous commit

[cloudflare-workers-and-pages]

Deploying atlantis with    Cloudflare Pages

Latest commit:	1328c0b
Status:	✅  Deploy successful!
Preview URL:	https://c5554bf5.atlantis.pages.dev
Branch Preview URL:	https://proof-of-concept-data-attrs.atlantis.pages.dev

View logs

[ZakaryH]

we would likely document either in the JSDoc, and on our main docs that this is a temporary/holdover pattern and that the preferred way is to simply use data attributes normally on components.

we would also want to include something either or on the props tables or descriptions for components and sub components stating that data attributes exist. maybe one day it would just be assumed they are available but while it's new and not readily available, having that noted would be nice.