Fixed UIChoiceBox for Authentication mode configuration #583
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modes "WPA3 PSK" and "WPA2/WPA3 PSK" were not visible in the UI when manually selecting authentication modes, as the windows was two rows to short. Window::draw_border() steals two rows for the frame. Two more extra lines are needed by UIChoiceBox for title string+spacing => rows=count+2+2. - Adds option to abort the choicebox selection, like it is possible with the stringbox (BREAK/ESCAPE/RUNSTOP). - Removes duplicated handling of c==-1 and c==-2 in UIChoiceBox::poll(). See GideonZ#581.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modes "WPA3 PSK" and "WPA2/WPA3 PSK" were not visible in the UI when manually selecting authentication modes, as the windows was two rows to short. Window::draw_border() steals two rows for the frame. Two more extra lines are needed by UIChoiceBox for title string+spacing => rows=count+2+2.
Adds option to abort the choicebox selection, like it is possible with the stringbox (BREAK/ESCAPE/RUNSTOP).
Removes duplicated handling of c==-1 and c==-2 in UIChoiceBox::poll().
See #581.