Fixes web BASIC editor tokenizer bug with "DATA" statements #597
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BASIC editor in the web interface incorrectly tokenized the parameters of a DATA statement. Parameters of DATA are not tokenized by Commodore BASIC, so an expression like has to be treated as a string "1+2", and the "+" character must be preserved. Likewise for any other keywords/characters with tokens. Fixes bug GideonZ#552.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BASIC editor in the web interface incorrectly tokenized the parameters of a DATA statement.
Parameters of DATA are not tokenized by Commodore BASIC, so an expression like 1 + 2 has to be treated as a string "1+2", and the "+" character must be preserved. Likewise for any other keywords/characters with tokens.
Fixes bug #552.
Test program:
Here's what the expected Commodore BASIC result when entered manually (DATA parameters not tokenized):
Here's what it incorrectly looked like when the same BASIC text was uploaded via the web interface (DATA parameters incorrectly tokenized):
