Skip to content

Conversation

@umairishaq
Copy link

The addition provides the solution for glimpse # 397.

@CGijbels
Copy link
Contributor

@umairishaq thank you for the pull request.

Now when looking at the changes made. a lot of changes don't seem to be related to the proposed fix, but are rather related to the addition or removal of spaces, hence reformatting of the file.

Could you reapply your changes on the original formatted version so that it will be a lot clearer what the actual changes are?

Thanks a lot and sorry for the additional work this means

@avanderhoorn
Copy link
Contributor

+1 with @CGijbels here - https://github.com/Glimpse/Glimpse.Client/pull/55/files. Once its fixed we can do a better review.

@umairishaq
Copy link
Author

Thank you very much for the comments guys. I'll resubmit shortly.

@umairishaq
Copy link
Author

Should be good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants