Improve XHTML5 Compatibility #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by their hexa code, respectively 
 4: ©. XHTML5 compatibility: add <![CDATA[ ... ]]> around css and javascript content. Add a missing closing </div> in glimpse.render.shell.html and format the file.
Conflicts: source/glimpse.render.shell.html
HTML-Encode description and title fields as they can contains invalid characters (as & in the url) Update the compiled file glimpse.js
Conflicts: source/glimpse.js source/glimpse.render.shell.html source/test.html
Conflicts: source/glimpse.render.shell.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, I changed the javascript source file from Glimpse.Client.
I didn't touch neither glimpse.js as it is not a source file nor qunit.js as it's a dependancy.
The diff of source/glimpse.render.shell.html is a bit odd, but the only change is a at the end of the file.