Introduce Destination resource

[sreemoyee-basu]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_network_connectivity_destination`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1408 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1408 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 231 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 121 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

• google_network_connectivity_destination

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 30
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• networkconnectivity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample
• TestAccNetworkConnectivityDestination_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivityDestination_networkConnectivityDestinationBasicExample [Debug log]
TestAccNetworkConnectivityDestination_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[SirGitsalot]

LGTM except for a one line change.

I'll be out of the office for the next couple of weeks, but I'll try to take a look at some point during that time. If this is urgent, contact the Terraform team oncall (contact info at go/terraform)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1408 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1408 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 231 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 121 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

• google_network_connectivity_destination

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 33
Passed tests: 32
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• networkconnectivity

🟢 All tests passed!

View the build log

[shuyama1]

Rotating a new reviewer, since the assigned reviewer is out.

@modular-magician reassign-reviewer