[GCI] Terraform support for L2_DEDICATED Interconnect Attachments

[abhijeetkjha-google]

compute: Added the `l2Forwarding` field to the `google_compute_interconnect_attachment` resource.

compute: Added new enum values to the `type` field for the `google_compute_interconnect_attachment` resource.

compute: Added new enum values to the `requestedFeatures` field for the `google_compute_interconnect` resource.

compute: Added new enum values to the `availableFeatures` field for the `google_compute_interconnect` resource.

This feature allows customers to route L2 traffic flows to GCP. L2 packets are forwarded between the on-premise router and GCP VMs, where GCP will perform GENEVE encapsulation to route the packets to and from the VM.

The L2 Interconnect attachments eliminates the need for customers to maintain infrastructure in the Colo and saves ongoing operational expenses. Connectivity and security providers who offer L2 services can run their infrastructure in the cloud with minimal redesigning of their L2-based software.

Please note: When type L2_DEDICATED is set, the following fields must not be configured:

• router
• cloudRouterIpAddress
• customerRouterIpAddress
• pairingKey
• vlanTag8021q
• candidateSubnets
• partnerMetadata
• partnerAsn
• ipsecInternalAddresses
• stackType
• cloudRouterIpv6Address
• customerRouterIpv6Address
• cloudRouterIpv6InterfaceId
• customerRouterIpv6InterfaceId
• subnetLength
• encryption

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 534 insertions(+), 37 deletions(-))
google-beta provider: Diff ( 6 files changed, 534 insertions(+), 37 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field encryption default value changed from NONE to <nil> on google_compute_interconnect_attachment - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 534 insertions(+), 37 deletions(-))
google-beta provider: Diff ( 6 files changed, 534 insertions(+), 37 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field encryption default value changed from NONE to <nil> on google_compute_interconnect_attachment - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 535 insertions(+), 37 deletions(-))
google-beta provider: Diff ( 6 files changed, 535 insertions(+), 37 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field encryption default value changed from NONE to <nil> on google_compute_interconnect_attachment - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1230
Skipped tests: 84
Affected tests: 5

Click here to see the affected service packages

• compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_computeInterconnectAttachmentCustomRangesExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentCustomRangesExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_l2DedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1230
Skipped tests: 84
Affected tests: 5

Click here to see the affected service packages

• compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_computeInterconnectAttachmentCustomRangesExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 534 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 6 files changed, 534 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentCustomRangesExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_l2DedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 534 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 6 files changed, 534 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1230
Skipped tests: 84
Affected tests: 5

Click here to see the affected service packages

• compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_computeInterconnectAttachmentCustomRangesExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample
• TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_computeInterconnectAttachmentCustomRangesExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentDedicatedExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_l2DedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 534 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 6 files changed, 534 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1232
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_l2DedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1232
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_l2DedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1233
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_l2DedicatedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 580 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 6 files changed, 580 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 156 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1233
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeInterconnectAttachment_l2DedicatedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInterconnectAttachment_l2DedicatedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[abhijeetkjha-google]

Hi @NickElliot, I see, TestAccComputeFutureReservation_sharedFutureReservationExample is failing with the following error.

Error recording tests:
error running go: exit status 1
stdout:
=== RUN   TestAccComputeFutureReservation_sharedFutureReservationExample
=== PAUSE TestAccComputeFutureReservation_sharedFutureReservationExample
=== CONT  TestAccComputeFutureReservation_sharedFutureReservationExample
    resource_compute_future_reservation_generated_test.go:182: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # google_compute_future_reservation.gce_future_reservation will be updated in-place
          ~ resource "google_compute_future_reservation" "gce_future_reservation" {
                id                                    = "projects/tf-test2o0bi4li1l/zones/us-central1-a/futureReservations/tf-test-gce-shared-future-reservation2o0bi4li1l"
                name                                  = "tf-test-gce-shared-future-reservation2o0bi4li1l"
                # (15 unchanged attributes hidden)
        
              ~ share_settings {
                  ~ projects   = [
                      - "560219336060",
                    ]
                    # (1 unchanged attribute hidden)
        
                    # (1 unchanged block hidden)
                }
        
              - specific_sku_properties {
                  - total_count              = "0" -> null
                    # (1 unchanged attribute hidden)
        
                  - instance_properties {
                      - maintenance_freeze_duration_hours = 0 -> null
                        # (4 unchanged attributes hidden)
                    }
                }
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccComputeFutureReservation_sharedFutureReservationExample (124.58s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute	124.652s
FAIL
stderr:

But this test seems to be unrelated to my change. Can you please help me with the next steps?

[zli82016]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 580 insertions(+), 30 deletions(-))
google-beta provider: Diff ( 6 files changed, 580 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 156 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1319
Passed tests: 1233
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeFutureReservation_sharedFutureReservationExample
• TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[abhijeetkjha-google]

🟢 Tests passed during RECORDING mode: TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

These tests are not related to these changes.

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.