Skip to content

Conversation

@hsmatulis
Copy link
Collaborator

Inverts the build tag logic to ensure that standard go build commands produce self-contained binaries with embedded assets. The dev workflow allowing for live updates must be explicitly specified now.

@hsmatulis hsmatulis force-pushed the hsmatulis-build-tags branch 2 times, most recently from 326630f to c983cd1 Compare December 11, 2025 07:57
@hsmatulis hsmatulis changed the title build(ui): make embedded assets the default behavior build(frontend): make embedded assets the default behavior Dec 11, 2025
@hsmatulis hsmatulis force-pushed the hsmatulis-build-tags branch from c983cd1 to bbcd53c Compare December 11, 2025 08:43
@bwplotka
Copy link
Collaborator

This could be also verified with test: #1822

Also if we do this let's ensure https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/hack/update-ui.sh works, can you double check that?

Inverts the build tag logic to ensure that standard `go build` commands produce self-contained binaries with embedded assets. The dev workflow allowing for live updates must be explicitly specified now.
@hsmatulis hsmatulis force-pushed the hsmatulis-build-tags branch from bbcd53c to 4aee2b8 Compare December 11, 2025 23:38
@hsmatulis
Copy link
Collaborator Author

This could be also verified with test: #1822

Yup! thats awesome, I'll rebase it

Also if we do this let's ensure https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/hack/update-ui.sh works, can you double check that?

Hmm it looks like that script is already failing at head, and has been since this commi 3 years ago: 26581ba

Looks like we removed the static/.gitignore dir that touch static/.gitignorein the script expects

Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer to keep the current state of things.

Perhaps more work vs benefits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants