Move fish completion to vendor's directory #4036
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Werkov
force-pushed
the
fix-fix-completion-2
branch
from
ee3643f to
4809e7c
Compare
I noticed that task completions won't work recently but it can be "fixed" by symlinking the completions scripts from vendor_completions.d directory as described by fish docs [1]. Use this directory by default. Fixes GothenburgBitFactory#3023 [1] https://fishshell.com/docs/current/completions.html
Werkov
force-pushed
the
fix-fix-completion-2
branch
from
4809e7c to
5460eac
Compare
fish-devel ships its desired vendor completions path. Add support for this to CMakeLists.txt but make it all optional with sane default for environments that don't want fish in its build deps.
Werkov
force-pushed
the
fix-fix-completion-2
branch
from
5460eac to
69688d1
Compare
Collaborator
|
This looks OK to me, but I'd appreciate some feedback either from a package maintainer or a fish user before merging it! |
Contributor
Author
|
Heh, I'm a fish user, moving the completions file recovers the completions for me. |
Collaborator
|
Fair enough. @felixschurk if this looks OK to you, let's merge! |
Collaborator
|
Yes, looks fine. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that task completions won't work recently but it can be "fixed" by symlinking the completions scripts from vendor_completions.d directory as described by fish docs [1].
Use this directory by default.
Fixes #3023
Notice:
Not testedCI tested, I'm open to adjustments if this is out of conventional style.[1] https://fishshell.com/docs/current/completions.html