Skip to content

Report information about symbol name in exception #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmichaelis merged 1 commit into from
Dec 20, 2025
Merged

Report information about symbol name in exception #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/zenkit/DaedalusVm.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ namespace zenkit {
template <typename R, typename... P>
void override_function(std::string_view name, std::function<R(P...)> const& callback) {
auto* sym = find_symbol_by_name(name);
if (sym == nullptr) throw DaedalusVmException {"symbol not found"};
if (sym == nullptr) throw DaedalusSymbolNotFound {std::string {name}};
if (sym->is_external()) throw DaedalusVmException {"symbol is already an external"};

if constexpr (!std::same_as<void, R>) {
Expand Down Expand Up @@ -571,8 +571,8 @@ namespace zenkit {
/// \param callback The C++ function to register as the external.
void override_function(std::string_view name, std::function<DaedalusNakedCall(DaedalusVm&)> const& callback) {
auto* sym = find_symbol_by_name(name);
if (sym == nullptr) throw DaedalusVmException {"symbol not found"};
if (sym->is_external()) throw DaedalusVmException {"symbol is already an external"};
if (sym == nullptr) throw DaedalusSymbolNotFound {std::string {name}};
if (sym->is_external()) throw DaedalusVmException {"symbol " + sym->name() + " is already an external"};

_m_function_overrides[sym->address()] = [callback](DaedalusVm& machine) { callback(machine); };
}
Expand Down
Loading