Skip to content

Conversation

@philip-paul-mueller
Copy link
Collaborator

This is a first draft that already works, kind of.
The workflow already works, not tested on this repo, but on my [development repo]https://github.com/philip-paul-mueller/test_package_index) it works already.

What is still missing:

  • Check if the wheel can be installed.
  • Install a hook in our DaCe fork, such that an update is triggered when it is updated (clarify condition when it is triggered).
  • Install a hook in the GHEX repo, such that an update is triggered when it is updated (clarify condition when it is triggered, clarify which version number should be used).

Copy link
Collaborator

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I think the current "pull" approach where the index repo request sources from the package repos and builds the wheels itself is the wrong design, and this repo should follow the opposite ("push") approach where the packages repos upload the wheel here.

Realistically, the current approach could be good enough as a first step and we don't need to change it if it works well for our purposes, so I'm ok with the current PR, although would like to add a comment about the two approaches in the README.

Also, instead of merging all the code in one PR, I would split the PR into two:

  • for the first one should be enough to just have one version of the important packages (DaCe and GHEX) uploaded by hand to test the functionality of serving as as index server
  • the second PR could add the update mechanism hooks, which in the worst case can be postponed a bit and do the updates manually for a while

Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
Copy link
Collaborator

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
@philip-paul-mueller philip-paul-mueller marked this pull request as ready for review December 2, 2025 15:29
Copy link
Collaborator

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philip-paul-mueller philip-paul-mueller merged commit 9d123f4 into main Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants