-
Notifications
You must be signed in to change notification settings - Fork 0
Enabling Automatization #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
egparedes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, I think the current "pull" approach where the index repo request sources from the package repos and builds the wheels itself is the wrong design, and this repo should follow the opposite ("push") approach where the packages repos upload the wheel here.
Realistically, the current approach could be good enough as a first step and we don't need to change it if it works well for our purposes, so I'm ok with the current PR, although would like to add a comment about the two approaches in the README.
Also, instead of merging all the code in one PR, I would split the PR into two:
- for the first one should be enough to just have one version of the important packages (DaCe and GHEX) uploaded by hand to test the functionality of serving as as index server
- the second PR could add the update mechanism hooks, which in the worst case can be postponed a bit and do the updates manually for a while
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
egparedes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
egparedes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a first draft that already works, kind of.
The workflow already works, not tested on this repo, but on my [development repo]https://github.com/philip-paul-mueller/test_package_index) it works already.
What is still missing: