Add Mel::Postgres adapter
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`break` exits the block preventing any code called after the block was yielded to run.
- `#orphan_score` -> `#orphan_timestamp` - `#running_score` -> `#running_timestamp` This gives it a more general name as "score" is specific to redis.
```
Failures:
1) Mel::Task #run does not retry beyond current schedule window
Failure/Error: Mel::PeriodicTask.find(id).try(&.attempts).should eq(0)
Expected: 0
got: 1
Error: # spec/mel/task_spec.cr:62
2) Mel::Task #run retries beyond current schedule window if task not rescheduled
Failure/Error: Mel::PeriodicTask.find(id).try(&.attempts).should eq(2)
Expected: 2
got: 1
Error: # spec/mel/task_spec.cr:84
3) Mel::Task #run deletes tasks from env after completion
Failure/Error: Mel::RunPool.fetch.should_not be_empty
Expected: Set{} not to be empty
Error: # spec/mel/task_spec.cr:107
4) Mel::Task .find_due skips running jobs
Failure/Error: Mel::InstantTask.find_due(count: -1, delete: nil).try(&.size).should eq(1)
Expected: 1
got: nil
Error: # spec/mel/task_spec.cr:214
Finished in 36.32 seconds
352 examples, 4 failures, 0 errors, 0 pending
Failed examples:
crystal spec spec/mel/task_spec.cr:49 # Mel::Task #run does not retry beyond current schedule window
crystal spec spec/mel/task_spec.cr:66 # Mel::Task #run retries beyond current schedule window if task not rescheduled
crystal spec spec/mel/task_spec.cr:97 # Mel::Task #run deletes tasks from env after completion
crystal spec spec/mel/task_spec.cr:211 # Mel::Task .find_due skips running jobs
Error: Process completed with exit code 1.
```
See <https://github.com/GrottoPress/mel/actions/runs/20850402291>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use Mel with PostgreSQL as store. Should work well for CockroachDB too.
This is probably a better alternative to using tools like Redka. See #6