Implement extensions mechanism and add HCKTrace #843

kostyanf14 · 2026-01-14T17:12:47Z

No description provided.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

gemini-code-assist · 2026-01-14T17:13:14Z

Summary of Changes

Hello @kostyanf14, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a robust extension mechanism, significantly enhancing the modularity and extensibility of the test framework. It enables the dynamic loading of additional functionalities, exemplified by the new HCKTrace integration for automated driver tracing. This change streamlines the process of adding custom behaviors and tools to the testing pipeline without modifying core logic, improving overall flexibility and diagnostic capabilities.

Highlights

New Extension Mechanism: A flexible mechanism has been introduced to define and load extensions, allowing for modular additions of functionality to the test execution process. This includes support for extra software, post-start commands, and test-specific configurations defined by extensions.
HCKTrace Integration: A new HCKTrace extension has been added, enabling automated driver tracing during test runs. This extension configures HCKTrace for driver tracing, starts recording before tests, stops recording after tests, and collects trace files.
CLI Option for Extensions: A new --extensions <extensions_list> CLI option is now available, allowing users to specify which extensions to load for a particular test run.
Dynamic Command Replacements: The system now provides @driver_short_name@ and @driver_dir@ replacement variables for guest run commands, which are especially useful when only a single driver is being tested, simplifying command definitions within extensions and test configurations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot

Pull request overview

This PR implements an extensions mechanism for the test framework and adds HCKTrace as the first extension. Extensions allow modular functionality to be added to tests without modifying driver configurations.

Changes:

Added Extension model with support for extra software, post-start commands, and test configurations
Integrated extensions throughout the test execution pipeline alongside drivers
Created HCKTrace extension for driver tracing during test execution

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
lib/models/extension.rb	New Extension model defining structure for modular test extensions
lib/models.rb	Registered Extension model in autoload list
lib/models/driver.rb	Changed extra_software from nilable to array with default for consistency
lib/engines/hcktest/hcktest.rb	Added extension loading, integrated extensions into post-start commands and test configurations
lib/engines/hcktest/tests.rb	Included extensions in test configuration selection logic
lib/setupmanagers/hckclient.rb	Added extension support in client setup and extracted driver replacement logic into new method
lib/engines/hcktest/extensions/hcktrace.json	HCKTrace extension configuration for driver tracing
lib/cli.rb	Added --extensions CLI option to specify extensions list
docs/Test-config-behavior.md	Documented new replacement variables for single-driver scenarios
lib/engines/hckinstall/hckinstall.rb	Refactored kit installer preparation into separate method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-14T17:14:24Z

lib/setupmanagers/hckclient.rb

    end

+    def insert_driver_replacement(driver, one_driver, replacement)
+      client_replacement = replacement.transform_keys { |k| k.dup.insert(1, "#{driver.short}.") }


This code assumes driver.short is non-nil, but the Driver model allows short to be T.nilable(String). If driver.short is nil, this will raise a NoMethodError when attempting string interpolation. Add a nil check or ensure driver.short is always present before calling this method.

Copilot · 2026-01-14T17:14:25Z

lib/engines/hcktest/extensions/hcktrace.json

+  "post_start_commands": [
+    {
+      "desc": "Configure HCKTrace service for driver tracing",
+      "guest_run": "Start-Process -Wait -FilePath hcktrace.exe -ArgumentList driver,@driver_short_name@,@driver_dir@,4"


The argument '4' at the end of the ArgumentList is unclear. Consider adding a comment in the JSON file or updating the desc field to explain what this numeric parameter represents (e.g., log level, trace verbosity).

Copilot · 2026-01-14T17:14:25Z

lib/cli.rb

                  &method(:fs_test_image_format=))
+
+        parser.on('--extensions <extensions_list>', Array,
+                  'List of extensions for run test',


Grammar issue: 'for run test' should be 'to run tests' or 'for running tests'.

Cursor VS Copilot haha

lib/engines/hcktest/hcktest.rb

gemini-code-assist

Code Review

This pull request introduces a valuable extensions mechanism, enhancing modularity. However, I've identified a critical bug in the prepare_extra_sw method that would prevent extra software from being installed correctly. Additionally, there's a high-severity issue in how driver-specific replacements are handled in multi-driver scenarios, which could lead to incorrect behavior. I've provided code suggestions to address both of these issues. The rest of the changes appear to correctly implement the new functionality.

lib/engines/hcktest/hcktest.rb

lib/setupmanagers/hckclient.rb

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

Extensions will be used to run some commands independently of the driver. We need this to have generic logic and prevent config duplication in drivers for external software. For example, to enable hcktrace extra software. Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

kostyanf14 · 2026-01-26T15:56:38Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new extensions mechanism, which allows for greater flexibility in test runs. The implementation is solid, following existing patterns in the codebase for consistency. A new HCKTrace extension is also added, serving as a great example of this new functionality. The changes are well-documented. I have a couple of minor suggestions to improve code conciseness. Overall, this is a great addition.

gemini-code-assist · 2026-01-26T15:58:04Z

lib/engines/hcktest/hcktest.rb

+      extra_softwares = []
+      extra_softwares += @drivers.flat_map(&:extra_software)
+      extra_softwares += @extensions.flat_map(&:extra_software)
+      extra_softwares += @project.engine_platform['extra_software'] || []


For conciseness, you can combine these array concatenations into a single expression.

extra_softwares = @drivers.flat_map(&:extra_software) + @extensions.flat_map(&:extra_software) + (@project.engine_platform['extra_software'] || [])

gemini-code-assist · 2026-01-26T15:58:04Z

lib/setupmanagers/hckclient.rb

+      @replacement_map.merge!({ '@driver_short_name@' => driver.short })
+      @replacement_map.merge!(replacement)


You can merge these two calls to merge! into a single call for better readability and conciseness.

@replacement_map.merge!({ '@driver_short_name@' => driver.short }, replacement)

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-26T16:02:20Z

lib/engines/hcktest/extensions/hcktrace.json

+  "post_start_commands": [
+    {
+      "desc": "Configure HCKTrace service for driver tracing",
+      "guest_run": "Start-Process -Wait -FilePath hcktrace.exe -ArgumentList driver,@driver_short_name@,@driver_dir@,4"


The HCKTrace extension uses placeholders that are only defined when there is exactly one driver being tested. If this extension is used with multiple drivers (e.g., in SVVP mode), the placeholders will not be replaced and the command will fail. Consider either documenting this limitation in a comment within the JSON file, or making the extension compatible with multiple drivers by using driver-specific placeholders like '@<driver_short_name>.driver_dir@' instead.

Fix RuboCop offenses

db7b4a0

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

Copilot AI review requested due to automatic review settings January 14, 2026 17:12

Copilot AI reviewed Jan 14, 2026

View reviewed changes

gemini-code-assist bot reviewed Jan 14, 2026

View reviewed changes

lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved

lib/setupmanagers/hckclient.rb Show resolved Hide resolved

hcktest: Simplify prepare_extra_sw logic

26f3845

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

kostyanf14 force-pushed the hcktrace-integration branch from c702b41 to 46f5803 Compare January 14, 2026 17:57

YanVugenfirer approved these changes Jan 15, 2026

View reviewed changes

kostyanf14 added 3 commits January 26, 2026 17:56

Add new replacments for test config

f5bf3fc

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

Add HCKTrace extension

ea9ab66

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>

kostyanf14 force-pushed the hcktrace-integration branch from 46f5803 to ea9ab66 Compare January 26, 2026 15:56

kostyanf14 requested a review from Copilot January 26, 2026 15:56

Copilot started reviewing on behalf of kostyanf14 January 26, 2026 15:56 View session

gemini-code-assist bot reviewed Jan 26, 2026

View reviewed changes

Copilot AI reviewed Jan 26, 2026

View reviewed changes

kostyanf14 merged commit 3219e3f into HCK-CI:master Jan 26, 2026
12 checks passed

kostyanf14 deleted the hcktrace-integration branch January 26, 2026 18:17

		@replacement_map.merge!({ '@driver_short_name@' => driver.short })
		@replacement_map.merge!(replacement)

Implement extensions mechanism and add HCKTrace #843

Implement extensions mechanism and add HCKTrace #843

Uh oh!

Conversation

kostyanf14 commented Jan 14, 2026

Uh oh!

gemini-code-assist bot commented Jan 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

kostyanf14 Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

kostyanf14 commented Jan 26, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants