-
Notifications
You must be signed in to change notification settings - Fork 3
Update message types for segmentation, feature extraction, and labeling #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TescaF
wants to merge
35
commits into
master
Choose a base branch
from
merge_seg_messages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erception into update_seg_messages
…. added labeling and knowledge messages to hlpr_perception_msgs
…erception into update_seg_messages
…erception into update_seg_messages
Three primary errors:
1. In all copies of utils.hpp, the definition of the method
cannot have default arguments, because the defaults are
already provided in the method declarations. This error
may be cropping up because I'm using a newer compiler.
2. when listing link libraries, we were using hardcoded paths
via the ROS_LIBRARIES CMake variable. This is provided
automatically by the catkin_LIBRARIES variable, so I switched
to using that instead in all the CMakeLists files.
3. hlpr_perception_msgs was not included as a dependency in all
packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted hlpr_segmentation, hlpr_feature_extraction, hlpr_object_labeling, and hlpr_knowledge_retrieval to use messages defined in hlpr_perception_msgs.