add tool_parser qwen3_xml for qwen3-coder models #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huiqiwa
requested review from
PatrykWo,
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
vivekgoe and
xuechendi
as code owners
Author
Signed-off-by: huiqiwa <huiqi.wang@intel.com>
huiqiwa
commented
Jan 4, 2026
|
|
||
| import regex as re | ||
|
|
||
| from vllm.entrypoints.chat_utils import random_tool_call_id |
Author
There was a problem hiding this comment.
I am porting qwen3xml_tool_parser.py from v0.11.1rc5. This parser requires make_tool_call_id, which is missing in 1.22. Our branch uses random_tool_call_id.
The make_tool_call_id switch was originally introduced to support Kimi models (see this commit), but our version of the tool parser does not yet support Kimi.
I see three ways to handle this:
Modify the ported parser to use our existing random_tool_call_id.
Backport the full commit that introduced make_tool_call_id and update all existing parsers for consistency.
Add make_tool_call_id as a new helper in chat_utils.py while keeping the old function.
@czhu15 Which way do we recommend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tool calling for Qwen3-Coder Models
Start server
bash start_gaudi_vllm_server.sh -w /data/hf_models/Qwen3-Coder-480B-A35B-Instruct-FP8 -s -d fp8 -t 8 -e "--enable-auto-tool-choice --tool-call-parser qwen3_xml"