-
Notifications
You must be signed in to change notification settings - Fork 9
Foundation: Databases - feedback from module #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adamblanchard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks a lot @magdazelena for taking your learnings and feedback from the session into tangible improvements here 🤩
They all look and sound great to me!
Two additional changes needed:
- Add the new dbeaver-ui.md to /SUMMARY.md so we can display it nicely on program.hackyourfuture.dk (otherwise it will just link to the raw github page)
- Because of that, we should rename "assets" to "session-materials", to match the naming pattern of our other modules, while we are here and making the url "public".
I don't know if you've worked with gitbook much before, but i'm happy to approve your PR and create a new one for those gitbook changes myself, if you'd like. Let me know!
| - JOIN links only matching rows based on a condition\*. | ||
| - Good idea is to JOIN on the **foreign key**! | ||
|
|
||
| \*_there are different types of JOIN. [Read more different types of JOIN in this article (out of scope)](https://www.w3schools.com/sql/sql_join.asp)._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to call this out
|
@adamblanchard made the requested changes, please check out :) |
adamblanchard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
After leading Database module in December, I got some thoughts and feedback from the trainees. Below my proposed changes:
Reasons:
Reasons:
Reasons: