Skip to content

Code Comments #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myrasmith wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Code Comments #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba35900
Update index.html
myrasmith Mar 25, 2021
a630460
Update style.css
myrasmith Mar 25, 2021
822391b
Update style.css
myrasmith Mar 25, 2021
65f7f51
Update index.js
myrasmith Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<!DOCTYPE html>
<!-- Nicely structured HTML! And good use of semantic HTML tags where appropriate. -->
<html lang="en">
<head>
<meta charset="UTF-8" />
Expand All @@ -23,6 +24,7 @@
</div>
<header>
<div class="logo">
<!-- Nice use of BEM class naming convention throughout! -->
<img class="logo__hm" src="./images/HM-logo.png" alt="HM Logo" width="50px">
<img src="./images/devhady.png" alt="DevHady Logo" width="150px" />
</div>
Expand Down
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const splash = document.querySelector('.splash')

// Is it necessary to use this event listener since you used defer?
document.addEventListener('DOMContentLoaded', (e) => {
setTimeout(() => {
splash.classList.add('display-none')
Expand All @@ -14,6 +15,8 @@ navToggle.addEventListener('click', () => {
document.body.classList.toggle('nav-open')
})

// Could you think of a way to accomplish this with a single event
// listener rather than an event listener for each nav link?
navLinks.forEach(link => {
link.addEventListener('click', () => {
document.body.classList.remove('nav-open')
Expand Down
19 changes: 15 additions & 4 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
}

/* Custom Properties, update these for my own design */

/*Nice use of CSS 'variables'*/
:root {
--ff-primary: "Source Sans Pro", sans-serif;
--ff-secondary: "Source Code Pro", monospace;
Expand Down Expand Up @@ -201,7 +201,9 @@ header {
transform: translateX(100%);
transition: transform 250ms cubic-bezier(.5, 0, .5, 1);
}

/*
Love this use of flexbox - the nav list is quite nicely laid out.
*/
.nav__list {
list-style: none;
display: flex;
Expand Down Expand Up @@ -390,7 +392,7 @@ header {

@media (min-width: 600px) {
.about-me {
display: grid;
display: grid; /*Love this grid on layout on larger screens!!!*/
grid-template-columns: 1fr 200px;
grid-template-areas:
"title img"
Expand All @@ -413,6 +415,7 @@ header {
padding-right: calc(200px + 4em);
}

/*As I resize the page, the aspect ratio of the image changes. How could you fix this? Is the height property necessary here?*/
.about-me__img {
grid-area: img;
position: relative;
Expand Down Expand Up @@ -472,6 +475,14 @@ text-align: center;

/* Adjust this for for mobile */

/*
Love to see you've got a start on changing the projects layout for mobile!
max-width: 300px is quite small - you might want to adjust that breakpoint!

The paragraphs in your skills section look quite nice on mobile - maybe you could use their styles as a guide for
How to update this media query!
*/

/* @media (max-width: 300px) {
.portfolio__item {
width: 10px;
Expand Down Expand Up @@ -525,4 +536,4 @@ text-align: center;

.social-list__link {
padding: .5em;
}
}