Check that activity has application_id before attempting to compare

[lambdan]

Been getting a few of these on timeplayed:

oblivionis-1  | 2025-12-13 14:08:23 ERROR    discord.client Ignoring exception in on_presence_update
oblivionis-1  | Traceback (most recent call last):
oblivionis-1  |   File "/app/.venv/lib/python3.13/site-packages/discord/client.py", line 449, in _run_event
oblivionis-1  |     await coro(*args, **kwargs)
oblivionis-1  |   File "/app/oblivionis/bot.py", line 90, in on_presence_update
oblivionis-1  |     if are_activities_equal(after_activity, before_activity):
oblivionis-1  |        ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
oblivionis-1  |   File "/app/oblivionis/bot.py", line 29, in are_activities_equal
oblivionis-1  |     return x.name == y.name and x.application_id == y.application_id
oblivionis-1  |                                 ^^^^^^^^^^^^^^^^
oblivionis-1  | AttributeError: 'Game' object has no attribute 'application_id'

Unsure what game, but this should fix it.

[lambdan]

Or maybe it would be better to return False if both don't have activity_id 🤔 If they are equal, both should have it...

[Hamuko]

My first idea is that either both have it or both don't have it, so I'd make the condition x.name == y.name and getattr(x, "application_id", None) == getattr(y, "application_id", None). If both have the same name and no application ID then they're equal. No idea if somehow some game has the same name but different IDs.

[lambdan]

I'm thinking this maybe

x_name = getattr(x, "name", "x")
y_name = getattr(y, "name", "y")
x_app_id = getattr(x, "application_id", "x")
y_app_id = getattr(y, "application_id", "y")
return x_name == y_name and x_app_id == y_app_id

[Hamuko]

Is intended that if both application IDs are Nonethat the comparison results to False?

[lambdan]

Hmm yeah that's true... didn't quite think it through. I'll change to your idea (name == name and id|None == id|None)

Also gonna see if I can figure out what game is causing this (I have a feeling its Roblox or TLauncher because a new user joined recently and that's what they're playing...)