This repository was archived by the owner on Jun 1, 2024. It is now read-only.
Multireddit dropdown list in drawer #3066
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexendoo
suggested changes
Sep 9, 2019
Member
Alexendoo
left a comment
Alexendoo
left a comment
There was a problem hiding this comment.
Thanks for the PR! Particular thanks for being brave enough to touch MainActivity
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
Outdated
Show resolved
Hide resolved
philippTheCat
force-pushed
the
feature/multireddit_dropdown
branch
from
9ffac05 to
b99f08a
Compare
Alexendoo
suggested changes
Sep 18, 2019
|
|
||
| drawerSubList.addHeaderView(header, null, false); | ||
| ((TextView) header.findViewById(R.id.name)).setText(Authentication.name); | ||
| header.findViewById(R.id.multi).setOnClickListener(new OnSingleClickListener() { |
Member
There was a problem hiding this comment.
With this removed it's not possible to open the regular MultiredditOverview
Alexendoo
reviewed
Sep 18, 2019
Member
Alexendoo
left a comment
Alexendoo
left a comment
There was a problem hiding this comment.
A final appearance thing, but you might also want to hide the dropdown if the user doesn't have any multireddits, since it still toggles but nothing appears underneath
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.