[Bug Fix] Make DDP workers set absl logging as default #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pretty file names to logs
emailweixu
previously approved these changes
Dec 10, 2025
Contributor
Author
|
Sorry, needs a restamp. Found out that pretty file names results in duplicate log files so removed it. |
emailweixu
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug recently where DDP worker log files were being created but not written to.
Ultimately discovered that this is caused by spawned subprocesses using python's logging module by default as they create a new interpreter. Adding
logging.use_absl_handler()(suggested by Wei) solves this issue.One mystery that remains is that hobot1 projects didn't seem to have this issue with no recent code changes to
train.pyoffering any hints. Low priority figuring this out for now as this new change fixes the current main.