Fix Identifier Missing References #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… discriminant in a switch case
There was a problem hiding this comment.
Pull Request Overview
This PR improves the robustness of identifier reference handling in the AST and extends test coverage to validate that every Identifier node is properly referenced or declared.
- Updated the mapIdentifierRelations function to fall back to scope.variableScope.references when scope.references is empty.
- Added a new test case to verify identifier referencing in the generated AST.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/flast.js | Modified identifier relation lookup logic to include a fallback to variableScope.references. |
| tests/parsing.test.js | Added a test case ensuring every Identifier node in the AST is either referenced or has a declaration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of identifier references in the
mapIdentifierRelationsfunction and adds a new test case to ensure correct referencing of identifiers in the generated AST. These changes enhance both functionality and test coverage.Improvements to identifier reference handling:
src/flast.js: Updated themapIdentifierRelationsfunction to handle cases wherescope.referencesmight be empty by falling back toscope.variableScope.references. This ensures more robust resolution of identifier references.Enhancements to test coverage:
tests/parsing.test.js: Added a new test case to verify that allIdentifiernodes in the AST are either referenced or have a declaration node. This ensures the correctness of identifier referencing in the AST.