Replaced MoveKey, ButtonInput, and PreButtonInput 1-4 with singular versions (plus a minor bugfix). #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires this PR or, more specifically, its changes to the MoveKey functions. The rest of it isn't mandatory.
This is about what it says on the tin. The four functions were functionally identical, so I saw no reason not to turn them into just one for the sake of reduced redundancy, simpler modification/future implementation, and potentially reducing the computer resources used by the mod. This PR changes nothing in-game except for the removal of what I presumed to be a bug - if you held an ability key down, then switched between the stand on/off states, you would execute the other ability immediately.