Skip to content

#27: fix absent velocities #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kraysent merged 1 commit into from
Sep 20, 2025
Merged

#27: fix absent velocities #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions src/components/ui/catalog-data.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ export function CatalogData({
}

if (catalogs?.velocity) {
data.push(
{
if (catalogs.velocity.heliocentric?.v !== undefined) {
data.push({
Parameter: "Heliocentric Velocity",
Value: (
<QuantityWithError
Expand All @@ -113,12 +113,15 @@ export function CatalogData({
>
<Quantity
value={catalogs.velocity.heliocentric?.v?.toFixed(0)}
unit={schema.units.velocity.heliocentric?.v}
unit={schema.units.velocity?.heliocentric?.v}
/>
</QuantityWithError>
),
},
{
});
}

if (catalogs.velocity.local_group?.v !== undefined) {
data.push({
Parameter: "Local Group Velocity",
Value: (
<QuantityWithError
Expand All @@ -127,12 +130,15 @@ export function CatalogData({
>
<Quantity
value={catalogs.velocity.local_group?.v?.toFixed(0)}
unit={schema.units.velocity.local_group?.v}
unit={schema.units.velocity?.local_group?.v}
/>
</QuantityWithError>
),
},
{
});
}

if (catalogs.velocity.cmb_old?.v !== undefined) {
data.push({
Parameter: "CMB (old) Velocity",
Value: (
<QuantityWithError
Expand All @@ -141,12 +147,15 @@ export function CatalogData({
>
<Quantity
value={catalogs.velocity.cmb_old?.v?.toFixed(0)}
unit={schema.units.velocity.cmb_old?.v}
unit={schema.units.velocity?.cmb_old?.v}
/>
</QuantityWithError>
),
},
{
});
}

if (catalogs.velocity.cmb?.v !== undefined) {
data.push({
Parameter: "CMB Velocity",
Value: (
<QuantityWithError
Expand All @@ -155,12 +164,12 @@ export function CatalogData({
>
<Quantity
value={catalogs.velocity.cmb?.v?.toFixed(0)}
unit={schema.units.velocity.cmb?.v}
unit={schema.units.velocity?.cmb?.v}
/>
</QuantityWithError>
),
},
);
});
}
}

return <CommonTable columns={columns} data={data} />;
Expand Down