Skip to content

Fix schema generation for embedded recursive structs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satvik007 merged 3 commits into from
Jul 22, 2025

Fix string length validation inconsistency between zod and validator …

924b7cd
Select commit
Loading
Failed to load commit list.
Merged

Fix schema generation for embedded recursive structs #17

Fix string length validation inconsistency between zod and validator …
924b7cd
Select commit
Loading
Failed to load commit list.
Cursor / Cursor BugBot completed Jul 22, 2025 in 5m 48s

BugBot Review

BugBot Analysis Progress (5m 50s elapsed)

✅ Gathered PR context (1s)
✅ Analyzed code changes (1s)
✅ Completed bug detection — 1 potential bug found (5m 45s)
✅ Validation and filtering completed (0s)
✅ Posted analysis results — 1 bug reported (2s)
✅ Analysis completed successfully (0s)

Final Result: BugBot completed review and found 1 potential issue

Request ID: serverGenReqId_a67b6325-feab-4467-b700-9ab9e59468ac

Details

Bug: String Length Validation Now Counts Code Points

String validation methods (len, min, max, gt, gte, lt, lte) now use custom .refine() functions with [...val].length instead of Zod's native .min(), .max(), and .length() methods. This changes string length counting from UTF-16 code units to Unicode code points/graphemes, leading to different validation results for multi-byte characters and emojis. This breaking change appears to be an accidental side effect unrelated to the PR's goal of fixing recursive embedded structs.

zod.go#L939-L970

zen/zod.go

Lines 939 to 970 in 924b7cd

case "oneof":
vals := splitParamsRegex.FindAllString(part[6:], -1)
for i := 0; i < len(vals); i++ {
vals[i] = strings.Replace(vals[i], "'", "", -1)
}
if len(vals) == 0 {
panic("oneof= must be followed by a list of values")
}
// const FishEnum = z.enum(["Salmon", "Tuna", "Trout"]);
validateStr.WriteString(fmt.Sprintf(".enum([\"%s\"] as const)", strings.Join(vals, "\", \"")))
case "len":
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length === %s, 'String must contain %s character(s)')", valValue, valValue))
case "min":
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length >= %s, 'String must contain at least %s character(s)')", valValue, valValue))
case "max":
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length <= %s, 'String must contain at most %s character(s)')", valValue, valValue))
case "gt":
val, err := strconv.Atoi(valValue)
if err != nil {
panic("gt= must be followed by a number")
}
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length > %d, 'String must contain at least %d character(s)')", val, val+1))
case "gte":
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length >= %s, 'String must contain at least %s character(s)')", valValue, valValue))
case "lt":
val, err := strconv.Atoi(valValue)
if err != nil {
panic("lt= must be followed by a number")
}
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length < %d, 'String must contain at most %d character(s)')", val, val-1))
case "lte":
refines = append(refines, fmt.Sprintf(".refine((val) => [...val].length <= %s, 'String must contain at most %s character(s)')", valValue, valValue))

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

View more details on Cursor