-
Notifications
You must be signed in to change notification settings - Fork 5
GH-12: Add Code of Conduct, Contributing Guidelines, and Issue Forms #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GH-12: Add Code of Conduct, Contributing Guidelines, and Issue Forms #13
Conversation
Move the `required` key from the `validations` key to the `options` array so the form correctly requires the checkbox to be ticked.
okunamayanad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from COC, everything seems fine. I quite like the questions chosen for the issue templates but I'm not familiar with GitHub issue templates and couldn't figure out how to test them properly. If they're working, the questions look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this is a code of conduct template. If so, I don't think making people read a code of conduct makes sense when the code of conduct isn't made for the project. These seem like common sense and things that should be kept the same across all open source projects anyways and I'd say making people read this would either introduce unnecessary friction for contributing or they would notice this is a template and just skip reading it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing your thoughts on this. I do see the point about the Contributor Covenant template feeling too generic or impersonal. However I don't see the issue with it "not being made for the project", since a code of conduct is usually meant to consistently apply within all community spaces, rather than being specific to a project. I hope I don't misunderstand you here when you say "project", I assumed it meant this repository. And while I also agree that most of the content seems like common sense and that the template might feel like it is too formal or too explicit, I do think it is important to state expectations clearly.
I am definitely open to rewriting it from scratch instead of using a template if that is preferred. I can shorten it and simplify the language as needed. My main goal is to have a consistent code of conduct across the community, that was the reason for choosing it as mentioned in the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I get a quick update on this? I would be happy to draft a new version of the code of conduct from scratch, but if a server admin wants to take the lead on that, I could instead create a new issue to just add the contributing guidelines and the issue forms, and then close this PR along with the related issue #12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I get a quick update on this? I would be happy to draft a new version of the code of conduct from scratch, but if a server admin wants to take the lead on that, I could instead create a new issue to just add the contributing guidelines and the issue forms, and then close this PR along with the related issue #12.
Hi, sorry for the late reply, I was a bit overwhelmed with the work going on https://github.com/HytaleModding/site and things in my personal life.
My thoughts on the coc template is that it should only contain things that you wouldn't just default to expecting. For example, the commit message structure if the project has one. Although I get the point that cocs are generally not used like this.
I was proposing to not have a coc if we're just going to have generic things. I wasn't sure about how others were thinking of this so instead of marking as changes requested, just left it as a comment. @ItsNeil17 could we get your ideas on this one too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see. I agree with keeping a single code of conduct across repositories. This is also something that can always be revisited later when things are less busy (like writing something short that's close to the rules on the Discord server and contains reporting guidelines), but I do think it's important to have one. I don't think there's anything else I can add here, if a decision is made, this conversation can be closed.
|
@dassenyy The issue templates you've made looks awesome! Could we also have them on the https://github.com/HytaleModding/site repo? I could add them and add you as a co-author or you could make a PR if you'd like. |
|
@okunamayanad Sure, you can add them to the site repository and list me as a co-author :) |
|
I have marked this PR as a draft, since I wanted to adjust the section "Setting up a Development Environment" in the contributing guidelines to include some info about setting up a development database, as this replaced the database file. |
|
@ItsNeil17 Alright this is done too now, updated README with new information about contributing standards and setting up a development environment, as well as info about configuring env variables like database connection options and the config file |
Changes
.github/from the.gitignoreto add issue forms.Attachments