-
Notifications
You must be signed in to change notification settings - Fork 122
Project - Adela Solís #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mucss-dataviz ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Enchufa2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments. Please always commit all files under _projects, there are some missing.
Please ensure that you follow the project guidelines: https://csslab.uc3m.es/dataviz/tutorials/project/#project-guidelines. And let me know when you have 100% completion by marking the pull request as "ready for review" again.
| self_contained: false | ||
| toc: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two must be indented properly (see the tutorial or other projects).
| ) | ||
| ``` | ||
|
|
||
| # Graph Replication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start at second level.
| font_add(family = "Castoro", | ||
| regular = "/Users/adelasolisolis/Data Visualization/dataviz/Castoro/Castoro-Regular.ttf") # custom font from google fonts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load it from Google Fonts directly and remove the local files.
| regular = "/Users/adelasolisolis/Data Visualization/dataviz/Castoro/Castoro-Regular.ttf") # custom font from google fonts | ||
|
|
||
| showtext_auto() | ||
| showtext_opts(dpi = 96) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove. Do not specify the dpi.
| ) | ||
| ``` | ||
|
|
||
| ## Create the Plot (Faceting, Color Scale, Size Scale, X / Y-Axis Scale, Labels and Theme Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid very long titles.
No description provided.